Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1428407

Re: [PATCH v13 01/16] PCI: Let pci_mmap_page_range() take resource address

Show all headers | View raw

On Sat, Jun 18, 2016 at 5:17 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Fri, Jun 17, 2016 at 07:24:46PM -0700, Yinghai Lu wrote:
>> In 8c05cd08a7 ("PCI: fix offset check for sysfs mmapped files"), try
>> to check exposed value with resource start/end in proc mmap path.
>>
>> |        start = vma->vm_pgoff;
>> |        size = ((pci_resource_len(pdev, resno) - 1) >> PAGE_SHIFT) + 1;
>> |        pci_start = (mmap_api == PCI_MMAP_PROCFS) ?
>> |                        pci_resource_start(pdev, resno) >> PAGE_SHIFT : 0;
>> |        if (start >= pci_start && start < pci_start + size &&
>> |                        start + nr <= pci_start + size)
>>
>> That breaks sparc that exposed value is BAR value, and need to be offseted
>> to resource address.
>
> I asked this same question of the v12 patch, but I don't think you
> answered it:
>
> I'm not quite sure what you're saying here.  Are you saying that sparc
> is currently broken, and this patch fixes it?  If so, what exactly is
> broken?  Can you give a small example of an mmap that is currently
> broken?

Yes, for sparc that path (proc mmap) is broken, but only according to
code checking.

The reason for the problem is not discovered is that seem all users
(other than x86) are not
use proc_mmap ?

vma->vm_pgoff is that code segment is User/BAR value >> PAGE_SHIFT.
pci_start is resource->start >> PAGE_SHIFT.

For sparc, resource start is different from BAR start aka pci bus address.
pci bus address add offset to be the resource start.

Thanks

Yinghai

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v13 01/16] PCI: Let pci_mmap_page_range() take resource address Yinghai Lu <yinghai@kernel.org> - 2016-06-18 04:30 +0200
  Re: [PATCH v13 01/16] PCI: Let pci_mmap_page_range() take resource  address Bjorn Helgaas <helgaas@kernel.org> - 2016-06-18 14:20 +0200
    Re: [PATCH v13 01/16] PCI: Let pci_mmap_page_range() take resource address Yinghai Lu <yinghai@kernel.org> - 2016-06-22 06:40 +0200
      Re: [PATCH v13 01/16] PCI: Let pci_mmap_page_range() take resource  address Bjorn Helgaas <helgaas@kernel.org> - 2016-06-22 17:30 +0200
        Re: [PATCH v13 01/16] PCI: Let pci_mmap_page_range() take resource address Yinghai Lu <yinghai@kernel.org> - 2016-06-22 21:30 +0200

csiph-web