Re: [PATCH 03/10] proc, oom_adj: extract oom_score_adj setting into a helper

From	"Hillf Danton" <hillf.zj@alibaba-inc.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/10] proc, oom_adj: extract oom_score_adj setting into a helper
Date	2016-06-22 05:20 +0200
Message-ID	<rMGRP-6mH-3@gated-at.bofh.it> (permalink)
References	<rMqal-3Th-11@gated-at.bofh.it> <rMqal-3Th-9@gated-at.bofh.it> <rMsOR-5ID-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > > diff --git a/fs/proc/base.c b/fs/proc/base.c
> > > index 968d5ea06e62..a6a8fbdd5a1b 100644
> > > --- a/fs/proc/base.c
> > > +++ b/fs/proc/base.c
> > > @@ -1037,7 +1037,47 @@ static ssize_t oom_adj_read(struct file *file, char __user *buf, size_t count,
> > >  	return simple_read_from_buffer(buf, count, ppos, buffer, len);
> > >  }
> > >
> > > -static DEFINE_MUTEX(oom_adj_mutex);
> > > +static int __set_oom_adj(struct file *file, int oom_adj, bool legacy)
> > > +{
> > > +	static DEFINE_MUTEX(oom_adj_mutex);
> >
> > Writers are not excluded for readers!
> > Is this a hot path?
> 
> I am not sure I follow you question. This is a write path... Who would
> be the reader?
> 
Currently oom_adj_read() and oom_adj_write() are serialized with 
task->sighand->siglock, and in this work oom_adj_mutex is introduced to
only keep writers in hose.

Plus, oom_adj_write() and oom_badness() are currently serialized 
with task->alloc_lock, and they may be handled in subsequent patches.

thanks
Hillf

Thread

Re: [PATCH 03/10] proc, oom_adj: extract oom_score_adj setting into a helper "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-06-21 11:30 +0200
  Re: [PATCH 03/10] proc, oom_adj: extract oom_score_adj setting into  a helper Michal Hocko <mhocko@kernel.org> - 2016-06-21 14:20 +0200
    Re: [PATCH 03/10] proc, oom_adj: extract oom_score_adj setting into a helper "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-06-22 05:20 +0200
      Re: [PATCH 03/10] proc, oom_adj: extract oom_score_adj setting into  a helper Michal Hocko <mhocko@kernel.org> - 2016-06-22 08:40 +0200

csiph-web