Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1428345

[RESEND PATCH 3/3] bcache: Remove redundant block_size assignment

Path csiph.com!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Yijing Wang <wangyijing@huawei.com>
Newsgroups linux.kernel
Subject [RESEND PATCH 3/3] bcache: Remove redundant block_size assignment
Date Wed, 22 Jun 2016 04:20:01 +0200
Message-ID <rMFVL-5L3-15@gated-at.bofh.it> (permalink)
X-Original-To <axboe@fb.com>, Kent Overstreet <kent.overstreet@gmail.com>
X-Mailer git-send-email 1.7.1
MIME-Version 1.0
Content-Type text/plain
X-Originating-IP [10.175.100.166]
X-Cfilter-Loop Reflected
X-Mirapoint-Virus-Rapid-Raw score=unknown(0), refid=str=0001.0A090206.5769F260.0020,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID 59b7bb70cf082131461b9e556a750cd8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc Eric Wheeler <git@linux.ewheeler.net>, Coly Li <colyli@suse.de>, <linux-bcache@vger.kernel.org>, <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Yijing Wang <wangyijing@huawei.com>
X-Original-Date Wed, 22 Jun 2016 10:12:24 +0800
X-Original-Message-ID <1466561544-19155-1-git-send-email-wangyijing@huawei.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1428345

Show key headers only | View raw


We have assigned sb->block_size before the switch,
so remove the redundant one.

Reviewed-by: Coly Li <colyli@suse.de>
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Acked-by: Eric Wheeler <bcache@lists.ewheeler.net>
---
 drivers/md/bcache/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index aecaace..bf4b100 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -134,7 +134,6 @@ static const char *read_super(struct cache_sb *sb, struct block_device *bdev,
 	case BCACHE_SB_VERSION_CDEV:
 	case BCACHE_SB_VERSION_CDEV_WITH_UUID:
 		sb->nbuckets	= le64_to_cpu(s->nbuckets);
-		sb->block_size	= le16_to_cpu(s->block_size);
 		sb->bucket_size	= le16_to_cpu(s->bucket_size);
 
 		sb->nr_in_set	= le16_to_cpu(s->nr_in_set);
-- 
1.7.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[RESEND PATCH 3/3] bcache: Remove redundant block_size assignment Yijing Wang <wangyijing@huawei.com> - 2016-06-22 04:20 +0200

csiph-web