Re: [PATCH] scripts/gdb: add constants.py to .gitignore

From	Kieran Bingham <kieran@ksquared.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scripts/gdb: add constants.py to .gitignore
Date	2016-06-22 00:10 +0200
Message-ID	<rMC1Q-3dH-9@gated-at.bofh.it> (permalink)
References	<rMdG9-4no-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Omar,

Thanks for spotting, and submitting this.

On 20/06/16 21:00, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> Since scripts/gdb/linux/constants.py is autogenerated, this should have
> been added to .gitignore when it was introduced.

Absolutely! - This never hit me, as I always build out-of-tree

> Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants")
> Signed-off-by: Omar Sandoval <osandov@fb.com>

Unfortunately - Nacked on the principle of the comment in the top of the
.gitignore file:

  # NOTE! Don't add files that are generated in specific
  # subdirectories here. Add them in the ".gitignore" file
  # in that subdirectory instead.

Could you fix this up (meaning add to the .gitignore under
scripts/gdb/linux) and resend please?

Then I'll add to my queue to send as fixes for current.
 (which I'm hoping to get sent before the weekend, or at the weekend)

> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 0c320bf02586..5cdccb07e3a3 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -112,3 +112,6 @@ all.config
>  
>  # Kdevelop4
>  *.kdev4
> +
> +# Generated for CONFIG_GDB_SCRIPTS
> +/scripts/gdb/linux/constants.py
> 

-- 
Regards

Kieran Bingham

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scripts/gdb: add constants.py to .gitignore Omar Sandoval <osandov@osandov.com> - 2016-06-20 22:10 +0200
  Re: [PATCH] scripts/gdb: add constants.py to .gitignore Kieran Bingham <kieran@ksquared.org.uk> - 2016-06-22 00:10 +0200

csiph-web