Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428181
| From | "Luis R. Rodriguez" <mcgrof@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Cocci] [PATCH v3 0/8] coccicheck: modernize |
| Date | 2016-06-21 23:30 +0200 |
| Message-ID | <rMBp7-2Kp-7@gated-at.bofh.it> (permalink) |
| References | <rMzwZ-1xY-3@gated-at.bofh.it> <rMAt3-29u-7@gated-at.bofh.it> <rMAW5-2lh-15@gated-at.bofh.it> <rMB5L-2DJ-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jun 21, 2016 at 11:02:49PM +0200, Julia Lawall wrote:
> On Tue, 21 Jun 2016, Luis R. Rodriguez wrote:
> > That is sanitized as follows:
> >
> > # spatch only allows include directories with the syntax "-I include"
> > # while gcc also allows "-Iinclude" and "-include include"
> > COCCIINCLUDE=${LINUXINCLUDE//-I/-I }
> > COCCIINCLUDE=${COCCIINCLUDE// -include/ --include}
>
> I don't get the second case. Is it to replace -include by --include?
> Coccinelle actually supports both, although it doesn't advertise that.
Oh neat, yeah. So a follow up patch later can be to remove that second line?
If so as of what version of coccinelle?
> Also, in LINUXINCLUDE, what is the meaning of -include? For Coccinelle,
> it is not the same as -I. It is for files that should be included that
> are not in the set of includes seen by whatever is the specified include
> strategy (--all-includes, etc). The argument is a specific file name, not
> a directory. It is a way of eg not bothering with --recursive-includes
> when there is one or a few key header files that each file will need.
Its used to force to include a single file, it is a file.
> > So the point is to annotate that the .cocconfig is picked up first due
> > to the fact make is used and its issued from the top level makefile
> > and starts from the top level. The fact that --dir is used is important
> > but secondary to its introduction as well.
>
> OK, the original text seemed to me to imply that running from the kernel
> directory was essential to getting the kernels .cocciconfig,
And what I meant to imply was that since coccicheck uses the kernel
makefiles it would kick off from kernel proper.
> so I wanted to point out that this is not the case.
I should have elaborated with all these details, its perhaps best to be
explicit about this so I can respin with a clearer commit log.
Luis
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/8] coccicheck: modernize "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 21:30 +0200
[PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 21:30 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 22:20 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 22:50 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 23:00 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:20 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 23:30 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:40 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-06-21 23:10 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 23:30 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:40 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:50 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-22 00:40 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-22 07:30 +0200
Re: [Cocci] [PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-22 17:20 +0200
Re: [Cocci] [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-22 21:50 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-22 00:00 +0200
Re: [PATCH v3 3/8] coccicheck: enable parmap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:30 +0200
[PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 21:30 +0200
Re: [PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 22:40 +0200
Re: [PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-06-21 23:50 +0200
[PATCH v3 4/8] coccicheck: replace --very-quiet with --quit when debugging "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 21:30 +0200
[PATCH v3 1/8] coccicheck: move spatch binary check up "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 21:30 +0200
Re: [PATCH v3 1/8] coccicheck: move spatch binary check up "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-06-21 22:40 +0200
[PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 21:30 +0200
Re: [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr> - 2016-06-21 23:20 +0200
Re: [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:20 +0200
Re: [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-22 02:10 +0200
Re: [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation Julia Lawall <julia.lawall@lip6.fr> - 2016-06-22 08:10 +0200
Re: [PATCH v3 0/8] coccicheck: modernize Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 22:30 +0200
Re: [Cocci] [PATCH v3 0/8] coccicheck: modernize "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 23:00 +0200
Re: [Cocci] [PATCH v3 0/8] coccicheck: modernize Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:10 +0200
Re: [Cocci] [PATCH v3 0/8] coccicheck: modernize "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 23:30 +0200
Re: [Cocci] [PATCH v3 0/8] coccicheck: modernize "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-21 23:40 +0200
Re: [Cocci] [PATCH v3 0/8] coccicheck: modernize Julia Lawall <julia.lawall@lip6.fr> - 2016-06-21 23:40 +0200
csiph-web