Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428164
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options |
| Date | 2016-06-21 23:10 +0200 |
| Message-ID | <rMB5L-2DJ-7@gated-at.bofh.it> (permalink) |
| References | <rKcbv-7f2-3@gated-at.bofh.it> <rKcbw-7f2-23@gated-at.bofh.it> <rLM3f-3BK-5@gated-at.bofh.it> <rLPu9-5V2-7@gated-at.bofh.it> <rMB5L-2DJ-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 21/06/2016 at 15:49:04 -0500, Rob Herring wrote : > So wouldn't you want to set one mode while running and the lower power > mode while suspended? I'm trying to understand the frequency of changing > this. If it is always one setting for a board, then yes it belongs in > DT. If it is a user decision, then it probably shouldn't be in DT. > > Seeing as these are reused, I've probably already had this discussion... > I would agree with Rob here. It may be better to provide a sysfs interface to configure that particular behavior. This is usually ok because the use case is: - the RTC is not configured, time has never been set - time is set for the first time - the user can set the oscillator mode/detection/... - on subsequent reboots, the mode is kept alongside the time and date I would advise against trying to set a mode automatically in the driver because you may have unexpected power cuts and it may then let the RTC consume more power than what you really want. > > > They should have vendor prefix and be explicit that they are boolean. > > > > I was trying to be consistent with ds1339 and ds1390 bindings which do > > not have vendor prefixes. Will fix in v2. > > Okay, then they are fine if you are using existing properties. Perhaps > these should all be in a common binding doc though. > I'll try to collect the existing common properties and write that doc this week. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-15 08:10 +0200
Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Rob Herring <robh@kernel.org> - 2016-06-19 16:40 +0200
Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-19 20:20 +0200
Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-21 23:10 +0200
Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-22 04:40 +0200
Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Andrey Smirnov <andrew.smirnov@gmail.com> - 2016-06-22 01:30 +0200
Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Rob Herring <robh@kernel.org> - 2016-06-22 05:30 +0200
csiph-web