Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426656

Re: [PATCH v3 2/3] block: convert to device_add_disk()

Show all headers | View raw

On Mon, Jun 20, 2016 at 6:33 AM, Bart Van Assche
<bart.vanassche@sandisk.com> wrote:
> On 06/17/2016 06:34 PM, Dan Williams wrote:
>>
>> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
>> index ef6b4d960bad..4e7cb5df8e43 100644
>> --- a/arch/um/drivers/ubd_kern.c
>> +++ b/arch/um/drivers/ubd_kern.c
>> @@ -823,12 +823,11 @@ static int ubd_disk_register(int major, u64 size,
>> int unit,
>>                 ubd_devs[unit].pdev.dev.release = ubd_device_release;
>>                 dev_set_drvdata(&ubd_devs[unit].pdev.dev,
>> &ubd_devs[unit]);
>>                 platform_device_register(&ubd_devs[unit].pdev);
>> -               disk->driverfs_dev = &ubd_devs[unit].pdev.dev;
>>         }
>>
>>         disk->private_data = &ubd_devs[unit];
>>         disk->queue = ubd_devs[unit].queue;
>> -       add_disk(disk);
>> +       device_add_disk(&ubd_devs[unit].pdev.dev, disk);
>>
>>         *disk_out = disk;
>>         return 0;
>
>
> Have you reviewed this patch yourself? I think the above change is an
> unintended behavior change.

Good catch! You are correct, this driver emits both parented an
un-parented disks.  I'll fix this up and re-check the others.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] Introduce device_add_disk() to kill  gendisk.driverfs_dev Dan Williams <dan.j.williams@intel.com> - 2016-06-17 18:40 +0200
  [PATCH v3 2/3] block: convert to device_add_disk() Dan Williams <dan.j.williams@intel.com> - 2016-06-17 18:40 +0200
    Re: [PATCH v3 2/3] block: convert to device_add_disk() Dan Williams <dan.j.williams@intel.com> - 2016-06-20 16:50 +0200
  [PATCH v3 1/3] block: introduce device_add_disk() Dan Williams <dan.j.williams@intel.com> - 2016-06-17 18:40 +0200

csiph-web