[PATCH] HID: alps: pass correct sizes to hid_hw_raw_request()

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH] HID: alps: pass correct sizes to hid_hw_raw_request()
Date	Mon, 20 Jun 2016 11:30:03 +0200
Message-ID	<rM3GP-6p3-49@gated-at.bofh.it> (permalink)
X-X-Sender	jkosina@pobox.suse.cz
User-Agent	Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, kbuild test robot <fengguang.wu@intel.com>
X-Original-Date	Mon, 20 Jun 2016 11:24:12 +0200 (CEST)
X-Original-Message-ID	<alpine.LNX.2.00.1606201122090.6874@cbobk.fhfr.pm>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1426394

Show key headers only | View raw

From: Jiri Kosina <jkosina@suse.cz>

Calculating size of the report as sizeof(pointer) always passess the 
length corresponding to the pointer type, not the underlying data report.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/hid/hid-alps.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 098bce6..ff64c929 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -136,7 +136,8 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address,
 
 	input[7] = check_sum;
 	ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input,
-			sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
+			sizeof(u8)*U1_FEATURE_REPORT_LEN, HID_FEATURE_REPORT,
+			HID_REQ_SET_REPORT);
 
 	if (ret < 0) {
 		dev_err(&hdev->dev, "failed to read command (%d)\n", ret);
@@ -145,8 +146,8 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address,
 
 	if (read_flag) {
 		ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, readbuf,
-				sizeof(readbuf), HID_FEATURE_REPORT,
-				HID_REQ_GET_REPORT);
+				sizeof(u8)*U1_FEATURE_REPORT_LEN,
+				HID_FEATURE_REPORT, HID_REQ_GET_REPORT);
 
 		if (ret < 0) {
 			dev_err(&hdev->dev, "failed read register (%d)\n", ret);
-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] HID: alps: pass correct sizes to hid_hw_raw_request() Jiri Kosina <jikos@kernel.org> - 2016-06-20 11:30 +0200

csiph-web