Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426288

Re: [PATCH v3] gpio: sch: Fix Oops on module load on Asus Eee PC 1201

Show all headers | View raw

On Sat, Jun 18, 2016 at 07:05:04PM +0100, Colin Pitrat wrote:
> This fixes the issue descirbe in bug 117531 
> (https://bugzilla.kernel.org/show_bug.cgi?id=117531).
> It's a regression introduced in linux 4.5 that causes a Oops at load of
> gpio_sch and prevents powering off the computer.
> 
> The issue is that sch_gpio_reg_set is called in sch_gpio_probe before
> gpio_chip data is initialized with the pointer to the sch_gpio struct. As
> sch_gpio_reg_set calls gpiochip_get_data, it returns NULL which causes
> the Oops.
> 
> The patch follows Mika's advice (https://lkml.org/lkml/2016/5/9/61) and
> consists in modifying sch_gpio_reg_get and sch_gpio_reg_set to take a
> sch_gpio struct directly instead of a gpio_chip, which avoids the call to
> gpiochip_get_data.
> 
> Thanks Mika for your patience with me :-)
> 
> Signed-off-by: Colin Pitrat <colin.pitrat@gmail.com>

Looks good now, thanks :)

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] gpio: sch: Fix Oops on module load on Asus Eee PC 1201 Colin Pitrat <colin.pitrat@gmail.com> - 2016-06-18 20:10 +0200
  Re: [PATCH v3] gpio: sch: Fix Oops on module load on Asus Eee PC 1201 Alexandre Courbot <gnurou@gmail.com> - 2016-06-19 09:10 +0200
  Re: [PATCH v3] gpio: sch: Fix Oops on module load on Asus Eee PC 1201 Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-20 09:50 +0200
  Re: [PATCH v3] gpio: sch: Fix Oops on module load on Asus Eee PC 1201 Linus Walleij <linus.walleij@linaro.org> - 2016-06-23 10:10 +0200

csiph-web