Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver
Date	2016-06-20 09:40 +0200
Message-ID	<rM1Ym-5hV-13@gated-at.bofh.it> (permalink)
References	<rKMRH-4YX-13@gated-at.bofh.it> <rKXWN-4zo-3@gated-at.bofh.it> <rLYxr-33g-9@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sun, Jun 19, 2016 at 08:54:32PM -0700, Bin Gao wrote:
> > > +#define DRV_NAME "bxt_wcove_gpio"
> > 
> > Drop this.
> We have _TWO_ places using DRV_NAME(near the end of the file):
> static struct platform_driver wcove_gpio_driver = {
>        .driver = {
>                .name = DRV_NAME,
>        },
> 
> and
> 
> MODULE_ALIAS("platform:" DRV_NAME);
> 
> You are suggesting to replace DRV_NAME with bxt_wcove_gpio(but why?)
> or something else?

Do instead this:

	.driver = {
		.name ="bxt_wcove_gpio",
	},

and

MODULE_ALIAS("platform:bxt_wcove_gpio");

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpio: add Intel WhiskeyCove GPIO driver Bin Gao <bin.gao@linux.intel.com> - 2016-06-16 23:20 +0200
  Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-17 11:10 +0200
    Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver Bin Gao <bin.gao@linux.intel.com> - 2016-06-20 06:00 +0200
      Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-20 09:40 +0200

csiph-web