Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support
Date	2016-06-20 08:10 +0200
Message-ID	<rM0zf-4zu-9@gated-at.bofh.it> (permalink)
References	<rLZWx-45v-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-06-20 at 10:57 +0530, Kedareswara rao Appana wrote:
> This patch adds support for gmii2rgmii converter
> in the macb driver.
[]
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
[]
> @@ -376,6 +389,20 @@ static int macb_mii_probe(struct net_device *dev)
>  	int phy_irq;
>  	int ret;
>  
> +	if (bp->gmii2rgmii_phy_node) {
> +		phydev = of_phy_attach(bp->dev,
> +				       bp->gmii2rgmii_phy_node,
> +				       0, 0);
> +		if (!phydev) {
> +			dev_err(&bp->pdev->dev, "%s: no gmii_to_rgmii found\n",
> +				dev->name);

why use dev_err(&bp->pdev->dev, ...) and not netdev_err(dev, ...) ?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH] net: macb: Add gmii2rgmii converter support Kedareswara rao Appana <appana.durga.rao@xilinx.com> - 2016-06-20 07:30 +0200
  Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support Florian Fainelli <f.fainelli@gmail.com> - 2016-06-20 07:40 +0200
    RE: [RFC PATCH] net: macb: Add gmii2rgmii converter support Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-06-20 08:20 +0200
  Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support Joe Perches <joe@perches.com> - 2016-06-20 08:10 +0200

csiph-web