[PATCH] brcmfmac: add missing break when deleting P2P_DEVICE

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Rafał Miłecki <zajec5@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] brcmfmac: add missing break when deleting P2P_DEVICE
Date	Sun, 19 Jun 2016 02:00:01 +0200
Message-ID	<rLyjD-2sd-5@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=966rtsEXIAAf+82BrbZmOpMLRFxjjxq27/nskukYhY0=; b=A7IBu8xCLBo80EJYasJPgGiD5gB8AT4tYNOhBsOdrQ4aXmlTkgn0+dT3Mh8KNFyC5X DnuytAeSZ6e3yIEi0+Fu3kIfOMsuumLXjUOXqDQPK1wwmjvA6KBXsMbyExN4ZOpjWcU9 ZtSrFjnr94BNwpMkzggCTbYXaZunNNgENcRkhFJkPvw9/b9e1SdwbhwQEmGzgebbpLa1 E5Pe/LgXkCVYU22wkWSxhR/1EarTUL0r5wlivf5+3K7d+Laq+QZbeXBSbroTARIOBdgR Tu8FncEMb1UAXp07O5UaUprScI2d0ZelOTX3hRC4XmBbb/SADBlEm52h7N13INUUKgUL aJ5w==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=966rtsEXIAAf+82BrbZmOpMLRFxjjxq27/nskukYhY0=; b=kPaKm0raR6h8z2QXhPN9+1uvDMkEqjodgRrpHf0huNb9Tnmk3m82Na92xFff8KlqQB FA45wsAfhSzrWKh4F7vaFOJoBmmNJFr0Dck12BVoeZ0wfqPPhulqq6+/oE1FyAGVbcxw eNROQ8fZUjXf55mOjidnxhAW4Kq+4YRcXHpKoMIoeiir9QxAnNV9Rxm37KlxgEGxOciG WdAeKkAWmcG3jQxWwq6BKdahYcRscPKtJn/CTrFm1kt8ZinFVvuWhFQkkSYlPv0KBDVy d0C3kEa+BoQKVbF0UBWsFH7U75CXW7RZv6+UBNID24BhK/SXekz7hMKBOodotP6qCyhx M1Aw==
X-Gm-Message-State	ALyK8tJGdj8IKl21yT/iGsUU89sLb0tkdhAYbtcryiMcOcswVw4tpLwFa1RaCE3MvdudoQ==
X-Received	by 10.25.17.209 with SMTP id 78mr2527313lfr.154.1466294224088; Sat, 18 Jun 2016 16:57:04 -0700 (PDT)
X-Mailer	git-send-email 1.8.4.5
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Rafał Miłecki <zajec5@gmail.com>, Arend van Spriel <arend.vanspriel@broadcom.com>, Franky Lin <franky.lin@broadcom.com>, Hante Meuleman <hante.meuleman@broadcom.com>, Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>, "Franky (Zhenhui) Lin" <frankyl@broadcom.com>, linux-wireless@vger.kernel.org (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), brcm80211-dev-list.pdl@broadcom.com (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list)
X-Original-Date	Sun, 19 Jun 2016 01:55:57 +0200
X-Original-Message-ID	<1466294168-8890-1-git-send-email-zajec5@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1425878

Show key headers only | View raw

We obviously don't want to fall through in that switch. With this change
1) We wait for event (triggered by p2p_disc) as expected
2) We remove interface manually on timeout
3) We return 0 on success instead of -ENOTSUPP

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 426ff05..f6241fd 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2261,6 +2261,8 @@ int brcmf_p2p_del_vif(struct wiphy *wiphy, struct wireless_dev *wdev)
 			return 0;
 		brcmf_p2p_cancel_remain_on_channel(vif->ifp);
 		brcmf_p2p_deinit_discovery(p2p);
+		break;
+
 	default:
 		return -ENOTSUPP;
 	}
-- 
1.8.4.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] brcmfmac: add missing break when deleting P2P_DEVICE Rafał Miłecki <zajec5@gmail.com> - 2016-06-19 02:00 +0200

csiph-web