Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425820

Re: [PATCH] blktrace: avoid using timespec

Show all headers | View raw

On Friday, June 17, 2016 5:54:16 PM CEST Jeff Moyer wrote:
> Jens Axboe <axboe@kernel.dk> writes:
> 
> > On 06/17/2016 05:36 PM, Steven Rostedt wrote:
> >>
> >> Jens,
> >>
> >> You want to take this, or do you want me to?
> >
> > I'll add it to my 4.8 tree, thanks Arnd.
> 
> +       /* need to check user space to see if this breaks in y2038 or y2106 */
> 
> Userspace just uses it to print the timestamp, right?  So do we need the
> comment?

If we have more details, the comment should describe what happens and
when it overflows. If you have the source at hand, maybe you can answer
these:

How does it print the timestamp? Does it print the raw seconds value
using %u (correct) or %d (incorrect), or does it convert it into
year/month/day/hour/min/sec?

In the last case, how does it treat second values above 0x80000000? Are
those printed as  year 2038 or year 1902?

Are we sure that there is only one user space implementation that reads
these values?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] blktrace: avoid using timespec Arnd Bergmann <arnd@arndb.de> - 2016-06-17 17:00 +0200
  Re: [PATCH] blktrace: avoid using timespec Steven Rostedt <rostedt@goodmis.org> - 2016-06-17 17:40 +0200
    Re: [PATCH] blktrace: avoid using timespec Jens Axboe <axboe@kernel.dk> - 2016-06-17 23:40 +0200
      Re: [PATCH] blktrace: avoid using timespec Jeff Moyer <jmoyer@redhat.com> - 2016-06-18 00:00 +0200
        Re: [PATCH] blktrace: avoid using timespec Arnd Bergmann <arnd@arndb.de> - 2016-06-18 21:10 +0200
          Re: [PATCH] blktrace: avoid using timespec Jeff Moyer <jmoyer@redhat.com> - 2016-06-20 17:10 +0200
            Re: [PATCH] blktrace: avoid using timespec Arnd Bergmann <arnd@arndb.de> - 2016-06-20 17:20 +0200
              Re: [PATCH] blktrace: avoid using timespec Jeff Moyer <jmoyer@redhat.com> - 2016-06-20 21:40 +0200
                Re: [Y2038] [PATCH] blktrace: avoid using timespec Arnd Bergmann <arnd@arndb.de> - 2016-06-20 22:10 +0200

csiph-web