Re: mwifiex: fix link error against sdio

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: mwifiex: fix link error against sdio
Date	Sat, 18 Jun 2016 15:40:01 +0200
Message-ID	<rLoDD-4Db-9@gated-at.bofh.it> (permalink)
References	<rKBtg-6qC-29@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Content-Type	text/plain; charset="utf-8"
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Amitkumar Karwar <akarwar@marvell.com>, Nishant Sarmukadam <nishants@marvell.com>, Arnd Bergmann <arnd@arndb.de>, Wei-Ning Huang <wnhuang@chromium.org>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 18 Jun 2016 13:36:52 +0000 (UTC)
X-Original-Message-ID	<20160618133652.BF4046144A@smtp.codeaurora.org>
X-Original-References	<20160616090206.932870-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1425719

Show key headers only | View raw

Arnd Bergmann <arnd@arndb.de> wrote:
> Calling sdio_claim_host() from the interface independent part of
> the mwifiex driver is not only a layering violation, but also causes
> a link error if MMC support is disabled, or if CONFIG_MMC=m
> and CONFIG_MWIFIEX=y:
> 
> drivers/net/built-in.o: In function `mwifiex_fw_dpc':
> :(.text+0xff138): undefined reference to `sdio_claim_host'
> :(.text+0xff158): undefined reference to `sdio_release_host'
> 
> The right way to do this is to have the sdio specific code in the
> sdio driver front-end, and we already have a callback pointer that
> we can use for this after exporting the generic fw download
> function from the core driver.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 65c71efe1c59 ("mwifiex: fix racing condition when downloading firmware")

Thanks, 1 patch applied to wireless-drivers-next.git:

2095b1426c9c mwifiex: fix link error against sdio

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9180095/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mwifiex: fix link error against sdio Arnd Bergmann <arnd@arndb.de> - 2016-06-16 11:10 +0200
  Re: mwifiex: fix link error against sdio Kalle Valo <kvalo@codeaurora.org> - 2016-06-18 15:40 +0200

csiph-web