Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425640
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper |
| Date | 2016-06-18 06:20 +0200 |
| Message-ID | <rLfTH-7zj-9@gated-at.bofh.it> (permalink) |
| References | <rL85P-2kS-21@gated-at.bofh.it> <rL9Oh-3wD-13@gated-at.bofh.it> <rLcVP-5DA-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/17/2016 06:08 PM, Brian Norris wrote:
> On Fri, Jun 17, 2016 at 02:41:51PM -0700, Guenter Roeck wrote:
>> On Fri, Jun 17, 2016 at 12:58:12PM -0700, Brian Norris wrote:
>>> +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev,
>>> + struct cros_ec_command *msg)
>>> +{
>>> + int ret;
>>> +
>>> + ret = cros_ec_cmd_xfer(ec_dev, msg);
>>> + if (ret < 0)
>>> + dev_err(ec_dev->dev, "Command xfer error (err:%d)\n", ret);
>>> + else if (msg->result != EC_RES_SUCCESS)
>>> + return -EECRESULT - msg->result;
>>
>> I have been wondering about the error return codes here, and if they should be
>> converted to standard Linux error codes. For example, I just hit error -1003
>> with a driver I am working on. This translates to EC_RES_INVALID_PARAM, or,
>> in Linux terms, -EINVAL. I think it would be better to use standard error
>> codes, especially since some of the errors are logged.
>
> How do you propose we do that? Do all of the following become EINVAL?
>
> EC_RES_INVALID_COMMAND
> EC_RES_INVALID_PARAM
> EC_RES_INVALID_VERSION
> EC_RES_INVALID_HEADER
>
Personal preference, but yes.
> We lose a lot of information that way. And particularly, cros_ec_num_pwms()
> won't be able to count as accurately. But I can just go back to not using this
You lost me there, sorry.
> API if that's what you'd like...
>
That isn't what I suggested.
Guenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/4] pwm: add support for ChromeOS EC PWM Brian Norris <briannorris@chromium.org> - 2016-06-17 22:00 +0200
[PATCH v3 1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Brian Norris <briannorris@chromium.org> - 2016-06-17 22:00 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Guenter Roeck <linux@roeck-us.net> - 2016-06-17 23:50 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Brian Norris <briannorris@chromium.org> - 2016-06-18 03:10 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Guenter Roeck <linux@roeck-us.net> - 2016-06-18 06:20 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Brian Norris <briannorris@chromium.org> - 2016-06-20 19:40 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Guenter Roeck <linux@roeck-us.net> - 2016-06-18 19:20 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-20 15:50 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Brian Norris <briannorris@chromium.org> - 2016-06-20 19:50 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-20 20:30 +0200
Re: [v3,1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Brian Norris <briannorris@chromium.org> - 2016-06-20 22:10 +0200
[PATCH v3 4/4] pwm: add ChromeOS EC PWM driver Brian Norris <briannorris@chromium.org> - 2016-06-17 22:00 +0200
[PATCH v3 3/4] doc: dt: pwm: add binding for ChromeOS EC PWM Brian Norris <briannorris@chromium.org> - 2016-06-17 22:00 +0200
csiph-web