Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425594

Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

Show all headers | View raw

Thanks!

On 2016/6/18 2:29, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> In case of error, the function devm_clk_get() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Reviewed-by: Chen Feng <puck.chen@hisilicon.com>
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index ed76baad..16834f4 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -965,21 +965,21 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx)
>  	}
>  
>  	ctx->ade_core_clk = devm_clk_get(dev, "clk_ade_core");
> -	if (!ctx->ade_core_clk) {
> +	if (IS_ERR(ctx->ade_core_clk)) {
>  		DRM_ERROR("failed to parse clk ADE_CORE\n");
> -		return -ENODEV;
> +		return PTR_ERR(ctx->ade_core_clk);
>  	}
>  
>  	ctx->media_noc_clk = devm_clk_get(dev, "clk_codec_jpeg");
> -	if (!ctx->media_noc_clk) {
> +	if (IS_ERR(ctx->media_noc_clk)) {
>  		DRM_ERROR("failed to parse clk CODEC_JPEG\n");
> -	    return -ENODEV;
> +		return PTR_ERR(ctx->media_noc_clk);
>  	}
>  
>  	ctx->ade_pix_clk = devm_clk_get(dev, "clk_ade_pix");
> -	if (!ctx->ade_pix_clk) {
> +	if (IS_ERR(ctx->ade_pix_clk)) {
>  		DRM_ERROR("failed to parse clk ADE_PIX\n");
> -	    return -ENODEV;
> +		return PTR_ERR(ctx->ade_pix_clk);
>  	}
>  
>  	return 0;
> 
> 
> 
> 
> 
> 
> .
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse() weiyj_lk@163.com - 2016-06-17 20:40 +0200
  Re: [PATCH -next] drm/hisilicon: Fix return value check in  ade_dts_parse() Chen Feng <puck.chen@hisilicon.com> - 2016-06-18 03:40 +0200
  Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse() Xinliang Liu <xinliang.liu@linaro.org> - 2016-06-20 04:00 +0200

csiph-web