Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426052

Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace

Show all headers | View raw

Let me first thank Pedro who has already replied!

And I have to admit I will need to re-read his explanations after
sleep to (try to) convince myself I fully understans the problems ;)
Too late for me.

Right now I have nothing to add, but

On 06/18, Andy Lutomirski wrote:
>
> @@ -922,16 +922,7 @@ static int putreg32(struct task_struct *child, unsigned regno, u32 value)
>  	R32(esp, sp);
>  
>  	case offsetof(struct user32, regs.orig_eax):
> -		/*
> -		 * A 32-bit debugger setting orig_eax means to restore
> -		 * the state of the task restarting a 32-bit syscall.
> -		 * Make sure we interpret the -ERESTART* codes correctly
> -		 * in case the task is not actually still sitting at the
> -		 * exit from a 32-bit syscall with TS_COMPAT still set.
> -		 */
>  		regs->orig_ax = value;
> -		if (syscall_get_nr(child, regs) >= 0)
> -			task_thread_info(child)->status |= TS_COMPAT;

I agree it would be nice to remove this code, but then it is not clear
how/when we should sign-extend regs->ax..

And this leads to another question, why do we actually need to set/clear
TS_COMPAT in set_personality_ia32() ??

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Andy Lutomirski <luto@kernel.org> - 2016-06-18 12:30 +0200
  Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Pedro Alves <pedro@palves.net> - 2016-06-18 16:00 +0200
    Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Pedro Alves <palves@redhat.com> - 2016-06-18 16:50 +0200
    Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Andy Lutomirski <luto@amacapital.net> - 2016-06-18 19:10 +0200
      Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Andy Lutomirski <luto@amacapital.net> - 2016-06-20 00:20 +0200
        Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Pedro Alves <pedro@palves.net> - 2016-06-20 12:30 +0200
        Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in  ptrace Oleg Nesterov <oleg@redhat.com> - 2016-06-20 18:40 +0200
          Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Andy Lutomirski <luto@amacapital.net> - 2016-06-20 18:50 +0200
            Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in  ptrace Oleg Nesterov <oleg@redhat.com> - 2016-06-20 19:20 +0200
              Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Andy Lutomirski <luto@amacapital.net> - 2016-06-20 19:30 +0200
      Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Pedro Alves <pedro@palves.net> - 2016-06-20 12:10 +0200
        Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Jan Kratochvil <jan.kratochvil@redhat.com> - 2016-06-20 13:20 +0200
  Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Kees Cook <keescook@chromium.org> - 2016-06-18 19:50 +0200
  Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Andy Lutomirski <luto@amacapital.net> - 2016-06-20 00:30 +0200
  Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in  ptrace Oleg Nesterov <oleg@redhat.com> - 2016-06-20 00:30 +0200
    Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace Andy Lutomirski <luto@amacapital.net> - 2016-06-20 08:20 +0200
      Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in  ptrace Oleg Nesterov <oleg@redhat.com> - 2016-06-20 18:40 +0200
      the usage of __SYSCALL_MASK in entry_SYSCALL_64/do_syscall_64 is not  consistent Oleg Nesterov <oleg@redhat.com> - 2016-06-20 20:10 +0200
        Re: the usage of __SYSCALL_MASK in entry_SYSCALL_64/do_syscall_64 is  not consistent Kees Cook <keescook@chromium.org> - 2016-06-21 21:10 +0200

csiph-web