Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for SPI3 related clocks

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Tomasz Figa <tomasz.figa@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for SPI3 related clocks
Date	Sun, 19 Jun 2016 15:50:01 +0200
Message-ID	<rLLgR-33m-1@gated-at.bofh.it> (permalink)
References	<rKXap-43m-9@gated-at.bofh.it> <rLpzH-5f3-9@gated-at.bofh.it> <rLDW1-6sS-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6ICsV9x/ul6osTTv1SyhorUcCWO+lnqLYswIPD08PME=; b=TXSAYjwqWs/MY/NEV5ogKNSwNzSwQBgrgi3c8FLkLS54rwHEt8zF40+U2QMIClmuDH XDp3FhZvM9/B19WqfkWuVANim+q0fFadMnXlc3QlCa1xuNeDLLlBrDEggVischNgXe4t 9CHhIVoEhVRwv2efmXHI4QU1/InzavIdKMDw0UwwWt4JX6gAG19X0z1G4cHwtvuEky99 +7WqvtRC358PfdX7l75jsFcjSHEenmdVsd7VbaBqITGYcRkVNbhkJGt994L3x/3IkcEP yc7qMGb8iYLT1jATiJa3NjAJw6VsHOs6nVwibWaRJqbCTqTfnU0A2nFkbktFXuJ+gPwB 7H0g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6ICsV9x/ul6osTTv1SyhorUcCWO+lnqLYswIPD08PME=; b=RbMHIVYqJqnCBmyMbvUkOobuJl6Nbf4QPpmgU1udruL//jCzUDmYdQcM+tdUSAmB/2 C8laUOr7Ry8o54zU/y3P2glwU80D7eh7PcwR0VhRQfw5dIpP/aAplFUqUNI7gOTmOtbg i+YMpywPFH8T2PEiFtspJ0fSPF2o9z3txJKxwa+3EL4P+RZSqC1LTCvyjMmVghU7PaJS kyuCzGoGZk87ypeXw0spuv3Q4KWD38YtHtq6G9cP19LVbKsLJQ48wQ/+vNNskfqcdeWj G3PNkC5RTpLmLMubQnULgTJP+EW//TY3qZ5j65QtDuSwHKDK9autnAxG6RC34Tgmy8L8 7Rtg==
X-Gm-Message-State	ALyK8tLOWUYCnU/MdADddTGx59W0AQa81LJcfW6B5xb527+oKDOP5Mo9M+WJgj5FyjQegoRKxRBlqlIJVsN4kg==
X-Received	by 10.129.135.1 with SMTP id x1mr6988060ywf.31.1466343860949; Sun, 19 Jun 2016 06:44:20 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	Andi Shyti <andi.shyti@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, linux-clk@vger.kernel.org, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, Jaehoon Chung <jh80.chung@samsung.com>
X-Original-Date	Sun, 19 Jun 2016 22:44:20 +0900
X-Original-Message-ID	<CA+Ln22HHNnPuEq1WVs+iiEEbAhdvkADhVkj99pqgR0qJODFUXw@mail.gmail.com>
X-Original-References	<1466151362-2881-1-git-send-email-andi.shyti@samsung.com> <CA+Ln22F9eskcpnFkrnVFc3dJqCJcJ5O-STfXC-8Om5MK-THwNg@mail.gmail.com> <20160619055921.GA424@jack.zhora.eu>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1425973

Show key headers only | View raw

2016-06-19 14:59 GMT+09:00 Andi Shyti <andi@etezian.org>:
> Hi Tomasz,
>
>> > The SPI 3 bus uses two clocks, a bus clock and an input clock.
>> > Do not disable the clocks when unused in order to allow access to
>> > the SPI 3 device.
>>
>> If unused, why would access to SPI 3 device needed?
>
> because next I will submit a small driver which uses the SPI3.
> Actually in the exynos5433 boards all the SPI are used but not all
> the drivers are ported to mainline.

Then shouldn't the driver request the clocks and enable them? Or I'm
missing something obvious? :)

Best regards,
Tomasz

Thread

[PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for  SPI3 related clocks Andi Shyti <andi.shyti@samsung.com> - 2016-06-17 10:20 +0200
  Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag  for SPI3 related clocks Tomasz Figa <tomasz.figa@gmail.com> - 2016-06-18 16:40 +0200
    Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag  for SPI3 related clocks Andi Shyti <andi@etezian.org> - 2016-06-19 08:00 +0200
      Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag  for SPI3 related clocks Tomasz Figa <tomasz.figa@gmail.com> - 2016-06-19 15:50 +0200
        Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for  SPI3 related clocks Andi Shyti <andi.shyti@samsung.com> - 2016-06-20 07:50 +0200
          Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag  for SPI3 related clocks Tomasz Figa <tomasz.figa@gmail.com> - 2016-06-20 11:10 +0200
            Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for  SPI3 related clocks Andi Shyti <andi.shyti@samsung.com> - 2016-06-20 12:30 +0200

csiph-web