Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425356

Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c to tree_exp.h

Show all headers | View raw

On Fri, Jun 17, 2016 at 11:48:12AM -0400, Pranith Kumar wrote:
> Hi Paul,
> 
> On Wed, Jun 15, 2016 at 5:46 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > People have been having some difficulty finding their way around the
> > RCU code.  This commit therefore pulls some of the expedited grace-period
> > code from tree.c to a new tree_exp.h file.  This commit is strictly code
> > movement, with the exception of a forward declaration that was added
> > for the sync_sched_exp_online_cleanup() function.
> >
> > A subsequent commit will move the remaining expedited grace-period code
> > from tree_plugin.h to tree_exp.h.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > ---
> >  kernel/rcu/tree.c     | 545 +-----------------------------------------------
> >  kernel/rcu/tree_exp.h | 564 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 566 insertions(+), 543 deletions(-)
> >  create mode 100644 kernel/rcu/tree_exp.h
> >
> 
> I've always wondered why you chose to only have a header file instead
> of the traditional x.h/x.c split for declarations and
> definitions(looking at tree_plugin.h). Is there any particular reason
> for this?

I didn't want to worry about function-call overhead, and doing it this
way allowed inlining.  Perhaps if link-time optimizations end up being
used heavily, I should go to the usual .h/.c split.

							Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH tip/core/rcu 0/12] Miscellaneous RCU fixes for 4.8 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 10/12] rcu: Fix a typo in a comment "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 07/12] rcu: No ordering for rcu_assign_pointer() of NULL "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
    Re: [PATCH tip/core/rcu 07/12] rcu: No ordering for  rcu_assign_pointer() of NULL Peter Zijlstra <peterz@infradead.org> - 2016-06-16 00:10 +0200
      Re: [PATCH tip/core/rcu 07/12] rcu: No ordering for  rcu_assign_pointer() of NULL Peter Zijlstra <peterz@infradead.org> - 2016-06-16 00:20 +0200
        Re: [PATCH tip/core/rcu 07/12] rcu: No ordering for  rcu_assign_pointer() of NULL "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-16 00:50 +0200
  [PATCH tip/core/rcu 02/12] rcu: Fix outdated hotplug-exclusion comment in rcu_gp_init() "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 03/12] rcu: Remove some superfluous lines "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c to tree_exp.h "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
    Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c  to tree_exp.h Peter Zijlstra <peterz@infradead.org> - 2016-06-16 00:10 +0200
      Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c  to tree_exp.h "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-16 00:20 +0200
    Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c  to tree_exp.h Pranith Kumar <bobby.prani@gmail.com> - 2016-06-17 17:50 +0200
      Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c  to tree_exp.h "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-17 19:50 +0200
  [PATCH tip/core/rcu 12/12] rcu: Correctly handle sparse possible cpus "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 08/12] rcu: Disable TASKS_RCU for usermode Linux "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
    Re: [PATCH tip/core/rcu 08/12] rcu: Disable TASKS_RCU for usermode  Linux Richard Weinberger <richard@nod.at> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 06/12] rcu: Document RCU_NONIDLE() restrictions in comment header "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 11/12] rcu: sysctl: Panic on RCU Stall "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 23:50 +0200
  [PATCH tip/core/rcu 05/12] rcu: Move expedited code from tree_plugin.h to tree_exp.h "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-16 00:00 +0200
  [PATCH tip/core/rcu 09/12] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-16 00:00 +0200
    Re: [PATCH tip/core/rcu 09/12] rcu: Make call_rcu_tasks() tolerate  first call with irqs disabled Peter Zijlstra <peterz@infradead.org> - 2016-06-16 00:20 +0200
      Re: [PATCH tip/core/rcu 09/12] rcu: Make call_rcu_tasks() tolerate  first call with irqs disabled "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-16 01:00 +0200
    Re: [PATCH tip/core/rcu 09/12] rcu: Make call_rcu_tasks() tolerate  first call with irqs disabled Peter Zijlstra <peterz@infradead.org> - 2016-06-16 00:20 +0200
      Re: [PATCH tip/core/rcu 09/12] rcu: Make call_rcu_tasks() tolerate  first call with irqs disabled "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-16 01:00 +0200

csiph-web