Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425308
| From | Johannes Weiner <hannes@cmpxchg.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/3] cgroup: remove unnecessary 0 check from css_from_id() |
| Date | 2016-06-17 18:30 +0200 |
| Message-ID | <rL4OC-qf-33@gated-at.bofh.it> (permalink) |
| References | <rKwtz-36W-9@gated-at.bofh.it> <rKLLX-4lm-5@gated-at.bofh.it> <rL4OB-qf-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
css_idr allocation starts at 1, so index 0 will never point to an
item. css_from_id() currently filters that before asking idr_find(),
but idr_find() would also just return NULL, so this is not needed.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
kernel/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 36fc0ff506c3..78f6d18ff0af 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -6162,7 +6162,7 @@ struct cgroup_subsys_state *css_tryget_online_from_dir(struct dentry *dentry,
struct cgroup_subsys_state *css_from_id(int id, struct cgroup_subsys *ss)
{
WARN_ON_ONCE(!rcu_read_lock_held());
- return id > 0 ? idr_find(&ss->css_idr, id) : NULL;
+ return idr_find(&ss->css_idr, id);
}
/**
--
2.8.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs Johannes Weiner <hannes@cmpxchg.org> - 2016-06-16 05:50 +0200
Re: [PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs Tejun Heo <tj@kernel.org> - 2016-06-16 22:10 +0200
[PATCH 3/3] mm: memcontrol: fix cgroup creation failure after many small jobs Johannes Weiner <hannes@cmpxchg.org> - 2016-06-17 18:30 +0200
Re: [PATCH 3/3] mm: memcontrol: fix cgroup creation failure after many small jobs Tejun Heo <tj@kernel.org> - 2016-06-17 20:20 +0200
Re: [PATCH 3/3] mm: memcontrol: fix cgroup creation failure after many small jobs Nikolay Borisov <kernel@kyup.com> - 2016-06-20 08:20 +0200
Re: [PATCH 3/3] mm: memcontrol: fix cgroup creation failure after many small jobs Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-06-21 12:40 +0200
Re: [PATCH 3/3] mm: memcontrol: fix cgroup creation failure after many small jobs Johannes Weiner <hannes@cmpxchg.org> - 2016-06-21 17:50 +0200
[PATCH 1/3] cgroup: fix idr leak for the first cgroup root Johannes Weiner <hannes@cmpxchg.org> - 2016-06-17 18:30 +0200
[PATCH 2/3] cgroup: remove unnecessary 0 check from css_from_id() Johannes Weiner <hannes@cmpxchg.org> - 2016-06-17 18:30 +0200
Re: [PATCH 2/3] cgroup: remove unnecessary 0 check from css_from_id() Tejun Heo <tj@kernel.org> - 2016-06-17 20:20 +0200
Re: [PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs Johannes Weiner <hannes@cmpxchg.org> - 2016-06-17 18:30 +0200
Re: [PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs Johannes Weiner <hannes@cmpxchg.org> - 2016-06-17 18:50 +0200
csiph-web