Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425286

Re: [PATCH] ata: fix "ering" sysfs time printing

Show all headers | View raw

On Fri, Jun 17, 2016 at 05:37:12PM +0200, Arnd Bergmann wrote:
> The sysfs file for the libata error handling has multiple issues
> in the way it prints time stamps:
> 
>  * it prints a 9-digit nanosecond value using a %06lu format string,
>    which drops some leading zeroes
>  * it converts a 64-bit jiffes value to a timespec using
>    jiffies_to_timespec(), which takes a 'long' argument, so the
>    result is wrong after a jiffies overflow (49 days).
>  * we try to avoid using timespec because that generally overflows
>    in 2038, although this particular usage is ok.
> 
> This replaces the jiffies_to_timespec call with an open-coded
> implementation that gets it right.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Heh, I'm not even sure why we're exposing this but it's already there.
Applied to libata/for-4.8.

Thanks!

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ata: fix "ering" sysfs time printing Arnd Bergmann <arnd@arndb.de> - 2016-06-17 17:40 +0200
  Re: [PATCH] ata: fix "ering" sysfs time printing Tejun Heo <tj@kernel.org> - 2016-06-17 18:20 +0200

csiph-web