Re: [PATCH v3 7/9] mm/page_owner: avoid null pointer dereference

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 7/9] mm/page_owner: avoid null pointer dereference
Date	Fri, 17 Jun 2016 15:40:02 +0200
Message-ID	<rL2a6-77b-23@gated-at.bofh.it> (permalink)
References	<rKWR3-3Hd-3@gated-at.bofh.it> <rKWR3-3Hd-25@gated-at.bofh.it>
X-Original-To	js1304@gmail.com, Andrew Morton <akpm@linux-foundation.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-2; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	mgorman@techsingularity.net, Minchan Kim <minchan@kernel.org>, Alexander Potapenko <glider@google.com>, Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sasha Levin <sasha.levin@oracle.com>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>, Joonsoo Kim <iamjoonsoo.kim@lge.com>
X-Original-Date	Fri, 17 Jun 2016 15:32:20 +0200
X-Original-Message-ID	<09cfe295-87d0-16d9-36ed-458378b3bd05@suse.cz>
X-Original-References	<1466150259-27727-1-git-send-email-iamjoonsoo.kim@lge.com> <1466150259-27727-8-git-send-email-iamjoonsoo.kim@lge.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1425092

Show key headers only | View raw

On 06/17/2016 09:57 AM, js1304@gmail.com wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>
> We have dereferenced page_ext before checking it. Lets check it first
> and then used it.
>
> Link: http://lkml.kernel.org/r/1465249059-7883-1-git-send-email-sudipm.mukherjee@gmail.com
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Hmm, this is already in mmotm as 
http://www.ozlabs.org/~akpm/mmotm/broken-out/mm-page_owner-use-stackdepot-to-store-stacktrace-fix.patch

But imho it's fixing a problem not related to your patch, but something that the 
commit f86e4271978b missed. So it should separately go to 4.7 ASAP.

Acked-by: Vlastimil Babka <vbabka@suse.cz>
Fixes: f86e4271978b ("mm: check the return value of lookup_page_ext for all call 
sites")


> ---
>  mm/page_owner.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index dc92241..ec6dc18 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -295,13 +295,15 @@ void __dump_page_owner(struct page *page)
>  		.skip = 0
>  	};
>  	depot_stack_handle_t handle;
> -	gfp_t gfp_mask = page_ext->gfp_mask;
> -	int mt = gfpflags_to_migratetype(gfp_mask);
> +	gfp_t gfp_mask;
> +	int mt;
>
>  	if (unlikely(!page_ext)) {
>  		pr_alert("There is not page extension available.\n");
>  		return;
>  	}
> +	gfp_mask = page_ext->gfp_mask;
> +	mt = gfpflags_to_migratetype(gfp_mask);
>
>  	if (!test_bit(PAGE_EXT_OWNER, &page_ext->flags)) {
>  		pr_alert("page_owner info is not active (free page?)\n");
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 7/9] mm/page_owner: avoid null pointer dereference js1304@gmail.com - 2016-06-17 10:00 +0200
  Re: [PATCH v3 7/9] mm/page_owner: avoid null pointer dereference Vlastimil Babka <vbabka@suse.cz> - 2016-06-17 15:40 +0200

csiph-web