Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425089

Re: [PATCH v3 9/9] mm/page_isolation: clean up confused code

Show all headers | View raw

On 06/17/2016 09:57 AM, js1304@gmail.com wrote:
> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> When there is an isolated_page, post_alloc_hook() is called with
> page but __free_pages() is called with isolated_page. Since they are
> the same so no problem but it's very confusing. To reduce it,
> this patch changes isolated_page to boolean type and uses page variable
> consistently.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Could be also just folded to mm/page_owner: initialize page owner without 
holding the zone lock

> ---
>  mm/page_isolation.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index 4639163..064b7fb 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -81,7 +81,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
>  {
>  	struct zone *zone;
>  	unsigned long flags, nr_pages;
> -	struct page *isolated_page = NULL;
> +	bool isolated_page = false;
>  	unsigned int order;
>  	unsigned long page_idx, buddy_idx;
>  	struct page *buddy;
> @@ -109,7 +109,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
>  			if (pfn_valid_within(page_to_pfn(buddy)) &&
>  			    !is_migrate_isolate_page(buddy)) {
>  				__isolate_free_page(page, order);
> -				isolated_page = page;
> +				isolated_page = true;
>  			}
>  		}
>  	}
> @@ -129,7 +129,7 @@ out:
>  	spin_unlock_irqrestore(&zone->lock, flags);
>  	if (isolated_page) {
>  		post_alloc_hook(page, order, __GFP_MOVABLE);
> -		__free_pages(isolated_page, order);
> +		__free_pages(page, order);
>  	}
>  }
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] reduce memory usage by page_owner js1304@gmail.com - 2016-06-17 10:00 +0200
  [PATCH v3 9/9] mm/page_isolation: clean up confused code js1304@gmail.com - 2016-06-17 10:00 +0200
    Re: [PATCH v3 9/9] mm/page_isolation: clean up confused code Vlastimil Babka <vbabka@suse.cz> - 2016-06-17 15:40 +0200
  [PATCH v3 5/9] tools/vm/page_owner: increase temporary buffer size js1304@gmail.com - 2016-06-17 10:00 +0200
    Re: [PATCH v3 5/9] tools/vm/page_owner: increase temporary buffer  size Vlastimil Babka <vbabka@suse.cz> - 2016-06-17 15:00 +0200
  [PATCH v3 1/9] mm/compaction: split freepages without holding the zone lock js1304@gmail.com - 2016-06-17 10:10 +0200
  [PATCH v3 3/9] mm/page_owner: copy last_migrate_reason in copy_page_owner() js1304@gmail.com - 2016-06-17 10:10 +0200

csiph-web