Re: [PATCH v2] mm: fix account pmd page to the process

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mm: fix account pmd page to the process
Date	2016-06-17 15:30 +0200
Message-ID	<rL20p-73O-7@gated-at.bofh.it> (permalink)
References	<rL1QJ-70p-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 17-06-16 21:13:12, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
> 
> huge_pmd_share accounts the number of pmds incorrectly when it races
> with a parallel pud instantiation. vma_interval_tree_foreach will
> increase the counter but then has to recheck the pud with the pte lock
> held and the back off path should drop the increment. The previous
> code would lead to an elevated pmd count which shouldn't be very
> harmful (check_mm() might complain and oom_badness() might be marginally
> confused) but this is worth fixing.

Kirill has posted a patch which is imho better [1]

[1] http://lkml.kernel.org/r/20160617122506.GC6534@node.shutemov.name
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] mm: fix account pmd page to the process zhongjiang <zhongjiang@huawei.com> - 2016-06-17 15:20 +0200
  Re: [PATCH v2] mm: fix account pmd page to the process Michal Hocko <mhocko@kernel.org> - 2016-06-17 15:30 +0200

csiph-web