Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425059

[Query] mwifiex: few observations to reduce number of endian conversions

Show all headers | View raw

Hi Amitkumar,

I have two observations:

1. I have found that in the command response path for host command
"HostCmd_CMD_802_11_EEPROM_ACCESS", a "0" value has been endian
converted. It can only be a safe futuristic approach for any non-zero
value there however! Otherwise, the endian conversion can be removed.

2. For multiple Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS
etc.) "cpu_to_leX"-converted values are saved to driver. So
"leX_to_cpu" conversion is required too many times afterwards in
driver.
On the contrary, we can save the values to driver without any
conversion, and only command buffer(s) are prepared with endian
converted values. In this way we can gain some efficiency [code size /
time] by reducing the number of endian conversion considerably.

Please let me know your opinion on the above.

-- 
Thanks,
Prasun

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[Query] mwifiex: few observations to reduce number of endian conversions Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-17 15:20 +0200
  RE: [Query] mwifiex: few observations to reduce number of endian  conversions Amitkumar Karwar <akarwar@marvell.com> - 2016-06-21 12:20 +0200
    Re: [Query] mwifiex: few observations to reduce number of endian conversions Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-21 13:00 +0200

csiph-web