Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1424982

Re: [PATCH v10 0/8] add i2c driver supported for rk3399

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [PATCH v10 0/8] add i2c driver supported for rk3399
Date 2016-06-17 14:00 +0200
Message-ID <rL0Bk-649-31@gated-at.bofh.it> (permalink)
References <rzrxf-85I-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, May 16, 2016 at 09:57:35PM +0800, David Wu wrote:
> There are three points differert from others:
>  - new method to caculate i2c timings for rk3399
>  - pclk and function clk are separated at rk3399
>  - add fast-plus mode supported for rk3399
> 
> David Wu (8):
>   i2c: rk3x: add documentation to fields in "struct rk3x_i2c"
>   i2c: rk3x: use struct "rk3x_i2c_calced_timings"
>   i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()
>   i2c: rk3x: Change SoC data to not use array
>   i2c: rk3x: Move spec timing data to "static const" structs
>   dt-bindings: i2c: rk3x: add support for rk3399
>   i2c: rk3x: add i2c support for rk3399 soc
>   i2c: rk3x: support fast-mode plus for rk3399
> 
>  Documentation/devicetree/bindings/i2c/i2c-rk3x.txt |  16 +-

Applied whole series to for-next, thanks! This was nicely refactored and
easy to review, thanks. Also thanks to all reviewers who helped this
series. I fixed one checkpatch issue for you, though:

WARNING: Statements should start on a tabstop
#278: FILE: drivers/i2c/busses/i2c-rk3x.c:789:
+	 if (min_div_for_hold >= min_total_div) {

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v10 0/8] add i2c driver supported for rk3399 Wolfram Sang <wsa@the-dreams.de> - 2016-06-17 14:00 +0200
  Re: [PATCH v10 0/8] add i2c driver supported for rk3399 "David.Wu" <david.wu@rock-chips.com> - 2016-06-20 04:30 +0200
  Re: [PATCH v10 0/8] add i2c driver supported for rk3399 "David.Wu" <david.wu@rock-chips.com> - 2016-06-20 04:30 +0200

csiph-web