Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1423596

Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660
Date 2016-06-16 02:30 +0200
Message-ID <rKtm1-1aF-15@gated-at.bofh.it> (permalink)
References <rK5D3-2WS-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/15, Linus Walleij wrote:
> @@ -426,10 +447,11 @@ static irqreturn_t qcom_rpm_ack_interrupt(int irq, void *dev)
>  	u32 ack;
>  	int i;
>  
> -	ack = readl_relaxed(RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
> -	for (i = 0; i < RPM_SELECT_SIZE; i++)
> -		writel_relaxed(0, RPM_CTRL_REG(rpm, RPM_ACK_SELECTOR + i));
> -	writel(0, RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
> +	ack = readl_relaxed(RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));
> +	for (i = 0; i < rpm->data->sel_size; i++)
> +		writel_relaxed(0,
> +			RPM_CTRL_REG(rpm, rpm->data->ack_sel_off + i));
> +	writel(0, RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));

Does the ack size vary though? I thought that was always 7. It
seems that really only the request selector size varies?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 Linus Walleij <linus.walleij@linaro.org> - 2016-06-15 01:10 +0200
  Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 Lee Jones <lee.jones@linaro.org> - 2016-06-15 10:40 +0200
  Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 Stephen Boyd <sboyd@codeaurora.org> - 2016-06-16 02:30 +0200
    Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 Linus Walleij <linus.walleij@linaro.org> - 2016-06-16 09:30 +0200

csiph-web