Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423461
| From | Sitsofe Wheeler <sitsofe@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2] block: correctly fallback for zeroout |
| Date | 2016-06-15 23:30 +0200 |
| Message-ID | <rKqxP-7NH-11@gated-at.bofh.it> (permalink) |
| References | <rHhhn-6ua-3@gated-at.bofh.it> <rHhhn-6ua-1@gated-at.bofh.it> <rKqxP-7NH-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jun 07, 2016 at 07:58:25AM -0700, Shaohua Li wrote: > > I didn't follow. io_err is only and always set when ret == 0. io_err is > meanless if ret != 0, because that means the disk doesn't support discard and > we don't dispatch discard IO. why should we initialized io_err to 0? My mistake - I confused what !ret would mean. Unfortunately the V2 patch no longer cleanly applies to the latest kernel (db06d759d6cf903aeda8c107fd3abd366dd80200 ) so I can't easily test it there. -- Sitsofe | http://sucs.org/~sits/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH V2] block: correctly fallback for zeroout Sitsofe Wheeler <sitsofe@gmail.com> - 2016-06-15 23:30 +0200
csiph-web