Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list
Date	2016-06-15 22:20 +0200
Message-ID	<rKps6-77R-37@gated-at.bofh.it> (permalink)
References	<rKps6-77R-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/15/2016 12:36 PM, Yannick Brosseau wrote:
> The execveat test try to exec the Makefile file and expect an EACCES results. When running
> the test in the installed destination it would fail with ENOENT since the file is
> not there.
> Add Makefile to the TEST_FILES list so it's copied at install time.
> 
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
>  tools/testing/selftests/exec/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
> index 4e400eb..d430060 100644
> --- a/tools/testing/selftests/exec/Makefile
> +++ b/tools/testing/selftests/exec/Makefile
> @@ -18,7 +18,8 @@ execveat.denatured: execveat
>  	$(CC) $(CFLAGS) -o $@ $^
>  
>  TEST_PROGS := execveat
> -TEST_FILES := $(DEPS)
> +# Makefile is a run-time dependency, since it's accessed by the execveat test
> +TEST_FILES := $(DEPS) Makefile
>  
>  include ../lib.mk
>  
> 

Thanks. Applied and queued for the next rc in linux-kselftest fixes branch

-- Shuah

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it  to the install list Shuah Khan <shuahkh@osg.samsung.com> - 2016-06-15 22:20 +0200

csiph-web