Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423414

Re: [PATCH] staging:vt6656:card.c:Fix comment block issue

Show all headers | View raw

On 11/06/16 21:08, Rithvik Patibandla wrote:
> Fix "Block comments use * on subsequent lines" and "Block comments use
> */ on trailing lines" warnings thrown by checkpatch.pl
> 
> Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com>
> ---
>  drivers/staging/vt6656/card.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index a382fc6..607834c 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -47,7 +47,8 @@
>  #include "usbpipe.h"
>  
>  /* const u16 cwRXBCNTSFOff[MAX_RATE] =
> -   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */
> + *   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3};
> + */
>  
>  static const u16 cwRXBCNTSFOff[MAX_RATE] = {
>  	192, 96, 34, 17, 34, 23, 17, 11, 8, 5, 4, 3
> 

Hi Rithvik,

The following warning is indeed fixed :) This patch looks good.

WARNING: Block comments use * on subsequent lines
#50: FILE: drivers/staging/vt6656/card.c:50:
+/* const u16 cwRXBCNTSFOff[MAX_RATE] =
+   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */


There are 32 other checks that checkpatch complains about in that file.
Please send fixes for those as well.

Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging:vt6656:card.c:Fix comment block issue Rithvik Patibandla <rithvikp98@gmail.com> - 2016-06-11 22:10 +0200
  Re: [PATCH] staging:vt6656:card.c:Fix comment block issue Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-15 22:30 +0200

csiph-web