Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

From	"Vesely, Jan" <Jan.Vesely@amd.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain
Date	2016-06-15 22:30 +0200
Message-ID	<rKpBL-7cb-3@gated-at.bofh.it> (permalink)
References	<rBjFf-6V9-7@gated-at.bofh.it> <rBjFf-6V9-5@gated-at.bofh.it> <rIb0e-lr-11@gated-at.bofh.it> <rKhEe-24C-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-06-15 at 13:54 +0200, joro@8bytes.org wrote:
> On Thu, Jun 09, 2016 at 03:48:44PM +0000, Vesely, Jan wrote:
> > On Sat, 2016-05-21 at 14:11 -0400, Jan Vesely wrote:
> > > From: Jan Vesely <jan.vesely@amd.com>
> > > 
> > > Signed-off-by: Jan Vesely <jan.vesely@amd.com>
> > > ---
> > >  drivers/iommu/amd_iommu.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/iommu/amd_iommu.c
> > > b/drivers/iommu/amd_iommu.c
> > > index 17c76f2..4ff5e40 100644
> > > --- a/drivers/iommu/amd_iommu.c
> > > +++ b/drivers/iommu/amd_iommu.c
> > > @@ -3016,6 +3016,7 @@ static void protection_domain_free(struct
> > > protection_domain *domain)
> > >  
> > >  	del_domain_from_list(domain);
> > >  
> > > +	mutex_destroy(&domain->api_lock);
> > >  	if (domain->id)
> > >  		domain_id_free(domain->id);
> > >  
> > 
> > ping
> 
> Your patches lack commit messages, please add a more detailed
> description of what you are fixing and why. Please also add 'Fixes:'
> tags when resubmitting. The changes itself look good to me.

There are no specific bugs/oopses that these patches fix (that I'm
aware of). Both were found while I was familiarizing myself with the
code looking for memory corruption (which turned out to be [0]).
Either issue would be very difficult to hit in the wild and
mutex_destroy is empty unless you compile using CONFIG_DEBUG_MUTEXES.

Jan

[0] https://lkml.org/lkml/2016/3/7/1087

> 
> 
> 	Joerg
>

Thread

Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain "joro@8bytes.org" <joro@8bytes.org> - 2016-06-15 14:00 +0200
  Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain "Vesely, Jan" <Jan.Vesely@amd.com> - 2016-06-15 22:30 +0200
    Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain Borislav Petkov <bp@alien8.de> - 2016-06-15 23:00 +0200

csiph-web