Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423411

Re: [PATCH 1/1] selinuxfs: fix type mismatch

Show all headers | View raw

On Fri, Jun 10, 2016 at 5:14 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> avc_cache_threshold is of type unsigned int.
>
> Do not use a signed new_value in
> sscanf(page, "%u", &new_value).
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  security/selinux/selinuxfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 1b1fd27..0765c5b 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -1347,7 +1347,7 @@ static ssize_t sel_write_avc_cache_threshold(struct file *file,
>  {
>         char *page;
>         ssize_t ret;
> -       int new_value;
> +       unsigned int new_value;
>
>         ret = task_has_security(current, SECURITY__SETSECPARAM);
>         if (ret)
> --
> 2.1.4
>



-- 
paul moore
www.paul-moore.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] selinuxfs: fix type mismatch Paul Moore <paul@paul-moore.com> - 2016-06-15 22:30 +0200

csiph-web