Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors
Date	2016-06-15 21:30 +0200
Message-ID	<rKoFH-6BZ-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <rKksq-3QZ-45@gated-at.bofh.it> <rKkVs-4hD-19@gated-at.bofh.it> <rKlHP-4PC-7@gated-at.bofh.it> <rKmDU-5r2-7@gated-at.bofh.it> <rKmNz-5ul-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 15, 2016 at 7:21 PM, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> On Wed, Jun 15, 2016 at 07:13:15PM +0200, Daniel Vetter wrote:
>> On Wed, Jun 15, 2016 at 6:17 PM, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
>> > On Wed, Jun 15, 2016 at 05:23:10PM +0200, Daniel Vetter wrote:
>> >> On Wed, Jun 15, 2016 at 03:51:34PM +0100, Liviu Dudau wrote:
>> >> > Add support for the new family of Display Processors from ARM Ltd.
>> >> > This commit adds basic support for Mali DP500, DP550 and DP650
>> >> > parts, with only the display engine being supported at the moment.
>> >> >
>> >> > Cc: David Brown <David.Brown@arm.com>
>> >> > Cc: Brian Starkey <Brian.Starkey@arm.com>
>> >> >
>> >> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
>> >>
>> >> Small thing I noticed: drm_dev_register/connector_register_all should be
>> >> the last step in your init code, and unregister the first. Atm it's
>> >> somewhere in the middle. But perfectly fine to do that as a follow-up.
>> >
>> > I've tried that, but the connector and encoder that gets registered as part
>> > of the component_bind_all() fails if there is no drm dev registered. You did
>> > comment on the v4 version about that and I did test your idea, sorry for
>> > forgeting to update you on that.
>>
>> Why does it fail? That shouldn't happen ... we need to be able to set
>> up everything first, before we register.
>
> Could be the tda998x_drv fault, but I'm getting this splat:

Yeah, tda9998x needs to be fixed to _not_ register it's connector
before the overall (componentized) driver is ready. We need to make
sure first ofc that all users of that driver do register connectors,
but Chris' patch series will take care of that. But tda9998x needs to
be fixed either way.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Thread

[PATCH v5 0/3] Add support for ARM Mali Display Processors Liviu Dudau <Liviu.Dudau@arm.com> - 2016-06-15 17:00 +0200
  [PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver Liviu Dudau <Liviu.Dudau@arm.com> - 2016-06-15 17:00 +0200
    Re: [PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver Eric Engestrom <eric.engestrom@imgtec.com> - 2016-06-15 17:40 +0200
      Re: [PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver Daniel Vetter <daniel@ffwll.ch> - 2016-06-15 18:20 +0200
        Re: [PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver Liviu Dudau <Liviu.Dudau@arm.com> - 2016-06-15 18:30 +0200
  Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Daniel Vetter <daniel@ffwll.ch> - 2016-06-15 19:20 +0200
    Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Daniel Vetter <daniel@ffwll.ch> - 2016-06-15 19:20 +0200
    Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Liviu Dudau <Liviu.Dudau@arm.com> - 2016-06-15 19:30 +0200
      Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Chris Wilson <chris@chris-wilson.co.uk> - 2016-06-15 19:40 +0200
        Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Liviu Dudau <Liviu.Dudau@arm.com> - 2016-06-15 19:50 +0200
      Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Daniel Vetter <daniel@ffwll.ch> - 2016-06-15 21:30 +0200
        Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-15 22:10 +0200
          Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Daniel Vetter <daniel@ffwll.ch> - 2016-06-15 22:40 +0200
      Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-06-15 22:20 +0200
        Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors Liviu Dudau <Liviu.Dudau@arm.com> - 2016-06-16 10:00 +0200

csiph-web