Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1423321

Re: [PATCH v3 2/2] media: et8ek8: Add documentation

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 2/2] media: et8ek8: Add documentation
Date 2016-06-15 20:50 +0200
Message-ID <rKo30-69o-7@gated-at.bofh.it> (permalink)
References <rITkB-4S0-5@gated-at.bofh.it> <rITkC-4S0-21@gated-at.bofh.it> <rK4GZ-2lJ-21@gated-at.bofh.it> <rKaMp-69a-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> Hi Rob,
>
> On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote:
>> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote:
>> > Add DT bindings description
>>
>> Not exactly the best commit msg.
>>
>> >
>> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>> > ---
>> >  .../bindings/media/i2c/toshiba,et8ek8.txt          | 50 ++++++++++++++++++++++
>> >  1 file changed, 50 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
>> > new file mode 100644
>> > index 0000000..997d268
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
>> > @@ -0,0 +1,50 @@
>> > +Toshiba et8ek8 5MP sensor
>> > +
>> > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
>> > +
>> > +More detailed documentation can be found in
>> > +Documentation/devicetree/bindings/media/video-interfaces.txt .
>> > +
>> > +
>> > +Mandatory properties
>> > +--------------------
>> > +
>> > +- compatible: "toshiba,et8ek8"
>> > +- reg: I2C address (0x3e, or an alternative address)
>> > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
>>
>> > +- clocks: External clock to the sensor
>> > +- clock-frequency: Frequency of the external clock to the sensor
>>
>> These should be mutually-exclusive. If you have a clock, then you can
>> get the frequency at runtime.
>
> Yes, you can. But the intention is to set the frequency: the sensor requires
> a particular, pre-determined frequency. Typically this is specific to the
> board.

Okay, then state that in the description.

Rob

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3 2/2] media: et8ek8: Add documentation Rob Herring <robh@kernel.org> - 2016-06-15 00:10 +0200
  Re: [PATCH v3 2/2] media: et8ek8: Add documentation Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-15 06:40 +0200
    Re: [PATCH v3 2/2] media: et8ek8: Add documentation Rob Herring <robh@kernel.org> - 2016-06-15 20:50 +0200
      Re: [PATCH v3 2/2] media: et8ek8: Add documentation Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-06-15 21:30 +0200
        Re: [PATCH v3 2/2] media: et8ek8: Add documentation Pavel Machek <pavel@ucw.cz> - 2016-06-18 16:40 +0200

csiph-web