Re: [PATCH 04/10] mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/10] mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj
Date	2016-06-15 17:10 +0200
Message-ID	<rKkC6-4aQ-9@gated-at.bofh.it> (permalink)
References	<rI6MV-5RF-3@gated-at.bofh.it> <rI6MW-5RF-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/09, Michal Hocko wrote:
>
> +			if (!p->vfork_done && process_shares_mm(p, mm)) {
> +				pr_info("updating oom_score_adj for %d (%s) from %d to %d because it shares mm with %d (%s). Report if this is unexpected.\n",
> +						task_pid_nr(p), p->comm,
> +						p->signal->oom_score_adj, oom_adj,
> +						task_pid_nr(task), task->comm);
> +				p->signal->oom_score_adj = oom_adj;

Personally I like this change.

And. I think after this change we can actually move ->oom_score_adj into mm_struct,
but lets discuss this later.

Oleg.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 04/10] mm, oom_adj: make sure processes sharing mm have  same view of oom_score_adj Oleg Nesterov <oleg@redhat.com> - 2016-06-15 17:10 +0200

csiph-web