Re: [PATCH 3/3] firmware: scpi: add device power domain support using genpd

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] firmware: scpi: add device power domain support using genpd
Date	2016-06-15 15:40 +0200
Message-ID	<rKjcZ-37G-21@gated-at.bofh.it> (permalink)
References	<rH56x-6VJ-11@gated-at.bofh.it> <rH56x-6VJ-23@gated-at.bofh.it> <rKiJY-2Ya-25@gated-at.bofh.it> <rKj3j-34D-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[...]

>
>>> +static const struct of_device_id scpi_power_domain_ids[] = {
>>> +       { .compatible = "arm,scpi-power-domains", },
>>> +       { /* sentinel */ }
>>> +};
>>
>>
>> Actually I think you shouldn't implement this a standalone driver and
>> thus you can remove this compatible.
>>
>
> While I tend to agree, I did this to keep it aligned with other SCPI
> users(clocks, sensors,.. for example).
>
> I assume remove compatible just from driver ? IMO, it doesn't make sense
> to add power domain provider without a compatible.
>
>> Instead, I think it's better if you let the arm_scpi driver to also
>> initialize the PM domain.
>>
>
> OK, I can do that.
>
>> If you still want the PM domain code to be maintained in a separate
>> file, just provide a header file which declares an
>> "scpi_pm_domain_init()" function (and a stub when not supported),
>> which the arm_scpi driver should call during ->probe().
>>
>
> I am fine with that, just that it deviates from the approach taken in
> other subsystems as I mentioned above.

If DT maintainers are happy with you adding a compatible for this,
don't let me stop you from implementing this as standalone driver.

I have no strong opinions about it, so perhaps it's then better to not
deviate from other cases!?

Kind regards
Uffe

Thread

Re: [PATCH 3/3] firmware: scpi: add device power domain support using genpd Ulf Hansson <ulf.hansson@linaro.org> - 2016-06-15 15:10 +0200
  Re: [PATCH 3/3] firmware: scpi: add device power domain support using  genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-15 15:30 +0200
    Re: [PATCH 3/3] firmware: scpi: add device power domain support using genpd Ulf Hansson <ulf.hansson@linaro.org> - 2016-06-15 15:40 +0200
      Re: [PATCH 3/3] firmware: scpi: add device power domain support using  genpd Sudeep Holla <sudeep.holla@arm.com> - 2016-06-15 15:50 +0200

csiph-web