Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423066

Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi irq

Show all headers | View raw

On Wed, Jun 15, 2016 at 6:42 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> This commit adds the infrastructure needed for threadable
> rx interrupt. A reference to the irq thread is used to
> mark the threaded irq mode.
> In threaded mode the poll loop is invoked directly from
> __napi_schedule().
> napi drivers which want to support threadable irq interrupts
> must provide an irq mode change handler which actually set
> napi->thread and register it after requesting the irq.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
>  include/linux/netdevice.h |  4 ++++
>  net/core/dev.c            | 59 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 63 insertions(+)
>

I really appreciate the effort, but as I already said this is not going to work.

Many NIC have 2 NAPI contexts per queue, one for TX, one for RX.

Relying on CFS to switch from the two 'threads' you need in the one
vCPU case will add latencies that your 'pure throughput UDP flood' is
not able to detect.

I was waiting a fix from Andy Lutomirski to be merged before sending
my ksoftirqd fix, which will work and wont bring kernel bloat.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] genirq: threadable IRQ support Paolo Abeni <pabeni@redhat.com> - 2016-06-15 15:50 +0200
  [PATCH 4/5] netdev: implement infrastructure for threadable napi irq Paolo Abeni <pabeni@redhat.com> - 2016-06-15 15:50 +0200
    Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi  irq kbuild test robot <lkp@intel.com> - 2016-06-15 16:20 +0200
    Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi irq Eric Dumazet <edumazet@google.com> - 2016-06-15 16:20 +0200
      Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi irq Eric Dumazet <edumazet@google.com> - 2016-06-15 16:30 +0200
      Re: [PATCH 4/5] netdev: implement infrastructure for threadable  napi irq Paolo Abeni <pabeni@redhat.com> - 2016-06-15 18:50 +0200
        Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi irq Eric Dumazet <edumazet@google.com> - 2016-06-15 19:10 +0200
          Re: [PATCH 4/5] netdev: implement infrastructure for threadable  napi irq Paolo Abeni <pabeni@redhat.com> - 2016-06-16 12:50 +0200
            Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi irq Eric Dumazet <edumazet@google.com> - 2016-06-16 13:20 +0200
              Re: [PATCH 4/5] netdev: implement infrastructure for threadable  napi irq Paolo Abeni <pabeni@redhat.com> - 2016-06-16 14:10 +0200
                Re: [PATCH 4/5] netdev: implement infrastructure for threadable napi irq Eric Dumazet <edumazet@google.com> - 2016-06-16 19:00 +0200

csiph-web