Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1423003

Re: [PATCH] clocksource: nps: fix nps_timer_init return value

From Daniel Lezcano <daniel.lezcano@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] clocksource: nps: fix nps_timer_init return value
Date 2016-06-15 15:20 +0200
Message-ID <rKiTD-31v-5@gated-at.bofh.it> (permalink)
References <rJGY1-2UX-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/13/2016 10:41 PM, Arnd Bergmann wrote:
> The CLOCKSOURCE_OF_DECLARE macro ensures that the type of the init
> function matches the caller. In case of the new timer-nps driver,
> it doesn't match, so we get a warning:
>
> ../drivers/clocksource/timer-nps.c:97:208: error: comparison of distinct pointer types lacks a cast [-Werror]
>   CLOCKSOURCE_OF_DECLARE(ezchip_nps400_clksrc, ezchip,nps400-timer,
>
> This changes the return type to match what the caller expects.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks, I integrated this change with the series.

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] clocksource: nps: fix nps_timer_init return value Arnd Bergmann <arnd@arndb.de> - 2016-06-13 22:50 +0200
  Re: [PATCH] clocksource: nps: fix nps_timer_init return value Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-15 15:20 +0200

csiph-web