Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison
Date	2016-06-15 11:20 +0200
Message-ID	<rKf9o-F4-27@gated-at.bofh.it> (permalink)
References	<rK5MJ-2ZU-3@gated-at.bofh.it> <rKe3D-8rI-3@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Wed, 2016-06-15 at 10:06 +0200, Ingo Molnar wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > +static const struct devs_id pcal9555a_1_dev_id __initconst = {
> > +	.name = "pcal9555a-1",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_2_dev_id __initconst = {
> > +	.name = "pcal9555a-2",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_3_dev_id __initconst = {
> > +	.name = "pcal9555a-3",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_4_dev_id __initconst = {
> > +	.name = "pcal9555a-4",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> 
> I have the same complaint as yesterday. Going forward could we please
> get nice 
> structure initializers in all future patches? :)

Oops, indeed. Sorry, will send new version soon.

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-15 01:20 +0200
  Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on  Edison Ingo Molnar <mingo@kernel.org> - 2016-06-15 10:10 +0200
    Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on  Edison Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-15 11:20 +0200

csiph-web