Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1422756

Re: [PATCH 2/4] scripts: add reqs python library

From Michal Marek <mmarek@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] scripts: add reqs python library
Date 2016-06-15 10:00 +0200
Message-ID <rKdTX-88q-9@gated-at.bofh.it> (permalink)
References <rK4QF-2oZ-11@gated-at.bofh.it> <rK4QG-2oZ-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 2016-06-15 00:10, Luis R. Rodriguez wrote:
> +        weight = (int(rel_specs['VERSION'])    << 32) + \
> +                 (int(rel_specs['PATCHLEVEL']) << 16) + \
> +                 (sublevel   		       << 8 ) + \
> +                 (extra * 60) + (relmod * 2)

This is going to silently break as soon as we have a version number with
e.g. a time stamp embedded. And there is actually no need to convert the
version string to an integer. You can convert them to arrays of
components and compare the components one by one.

Michal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] scripts: add reqs python library "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 00:20 +0200
  Re: [PATCH 2/4] scripts: add reqs python library Julia Lawall <julia.lawall@lip6.fr> - 2016-06-15 08:10 +0200
    Re: [PATCH 2/4] scripts: add reqs python library "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 18:10 +0200
  Re: [PATCH 2/4] scripts: add reqs python library Michal Marek <mmarek@suse.com> - 2016-06-15 10:00 +0200
    Re: [PATCH 2/4] scripts: add reqs python library "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 18:10 +0200
      Re: [PATCH 2/4] scripts: add reqs python library Michal Marek <mmarek@suse.com> - 2016-06-15 21:20 +0200
        Re: [PATCH 2/4] scripts: add reqs python library "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 22:30 +0200
          Re: [PATCH 2/4] scripts: add reqs python library Julia Lawall <julia.lawall@lip6.fr> - 2016-06-15 22:40 +0200
  Aw: [Cocci] [PATCH 2/4] scripts: add reqs python library "SF Markus Elfring" <elfring@users.sourceforge.net> - 2016-06-15 14:10 +0200
    Re: [Cocci] [PATCH 2/4] scripts: add reqs python library "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 18:00 +0200

csiph-web