Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1422652

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date 2016-06-15 08:30 +0200
Message-ID <rKcuS-7lr-13@gated-at.bofh.it> (permalink)
References <rJvT0-3Sn-13@gated-at.bofh.it> <rKbyN-6Lx-11@gated-at.bofh.it> <rKcuR-7lr-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Matt Wilson <msw@amzn.com>
Date: Tue, 14 Jun 2016 23:23:36 -0700

> Point taken, though existing drivers (even fairly popular ones) also
> aren't as clean as you might like. A quick look around...

Existing drivers do undesirable things, film at 11...

Yet are never a reason to accept such things in new drivers.

> Like many other network drivers, some of this is common code used for
> non-Linux systems, and that's why there is some overlap with Linux
> facilities.

Again, never an excuse for such things.

> Are there other things that jump out at you?

I review hundreds of patches a day, I invested what I was able to
before moving on to other people's work.

Other developers must help review such a large driver submission, it
can't all be on me.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic  Network Adapters (ENA) David Miller <davem@davemloft.net> - 2016-06-15 07:30 +0200
  Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic  Network Adapters (ENA) Matt Wilson <msw@amzn.com> - 2016-06-15 08:30 +0200
    Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic  Network Adapters (ENA) David Miller <davem@davemloft.net> - 2016-06-15 08:30 +0200
      Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic  Network Adapters (ENA) Matt Wilson <msw@amzn.com> - 2016-06-15 08:50 +0200

csiph-web