Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1422674
| From | Ganesh Mahendran <opensource.ganesh@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] mm/compaction: remove unnecessary order check in try_to_compact_pages() |
| Date | 2016-06-15 09:00 +0200 |
| Message-ID | <rKcXT-7xD-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The caller __alloc_pages_direct_compact() already check (order == 0). So no need to check again. Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com> --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index fbb7b38..500acda 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1687,7 +1687,7 @@ enum compact_result try_to_compact_pages(gfp_t gfp_mask, unsigned int order, *contended = COMPACT_CONTENDED_NONE; /* Check if the GFP flags allow compaction */ - if (!order || !may_enter_fs || !may_perform_io) + if (!may_enter_fs || !may_perform_io) return COMPACT_SKIPPED; trace_mm_compaction_try_to_compact_pages(order, gfp_mask, mode); -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] mm/compaction: remove unnecessary order check in try_to_compact_pages() Ganesh Mahendran <opensource.ganesh@gmail.com> - 2016-06-15 09:00 +0200 Re: [PATCH] mm/compaction: remove unnecessary order check in try_to_compact_pages() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-06-15 10:50 +0200
csiph-web