Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection

From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection
Date	2016-06-15 08:50 +0200
Message-ID	<rKcOd-7sd-19@gated-at.bofh.it> (permalink)
References	<rK8hz-4mM-3@gated-at.bofh.it> <rJXcu-5RE-53@gated-at.bofh.it> <rK8hz-4mM-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 15/06/16 04:57, Chanwoo Choi wrote:
> On 2016년 06월 14일 23:04, Roger Quadros wrote:
>> If USB cable is connected prior to boot, we don't get any interrupts
>> so we must manually check the VBUS state and report it during probe.
>> If we don't do it then USB controller will never know that peripheral
>> cable was connected till the user unplugs and replugs the cable.
>>
>> Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  drivers/extcon/extcon-palmas.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>> index 8b3226d..caff46c 100644
>> --- a/drivers/extcon/extcon-palmas.c
>> +++ b/drivers/extcon/extcon-palmas.c
>> @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>>  
>>  	palmas_enable_irq(palmas_usb);
>>  	/* perform initial detection */
>> +	if (palmas_usb->enable_gpio_vbus_detection)
>> +		palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
>>  	palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
>>  	device_set_wakeup_capable(&pdev->dev, true);
>>  	return 0;
>>
> 
> Applied it.

Thanks. But this is a bug fix and must go in v4.7-rc
as well as stable v4.6+.

Can you please add

Cc: stable@vger.kernel.org # v4.6+

--
cheers,
-roger

Thread

[PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection Roger Quadros <rogerq@ti.com> - 2016-06-14 16:10 +0200
  Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO  detection Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-15 04:00 +0200
    Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO  detection Roger Quadros <rogerq@ti.com> - 2016-06-15 08:50 +0200
      Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO  detection Chanwoo Choi <cw00.choi@samsung.com> - 2016-06-15 10:00 +0200
  [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO  detection Roger Quadros <rogerq@ti.com> - 2016-06-15 10:20 +0200

csiph-web