Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1422609

Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

Show all headers | View raw

From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
Date: Mon, 13 Jun 2016 20:41:22 +0800

> From: Kejian Yan <yankejian@huawei.com>
> 
> HNS receives a packet without doing anything, but it should call
> skb_reset_mac_header() to initialize the header before using
> eth_hdr().
> 
> Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619
> Signed-off-by: Kejian Yan <yankejian@huawei.com>
> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@huawei.com>

Well, this patch made me look at this function.

You really shouldn't be filtering packets looped back, that is
the stack's job.  It shouldn't be happening in the driver.

And once you remove that code, this patch here is no longer
necessary.

Second of all, unless you card supports every protocol that
exists in the past, present, and _future_ you cannot set
skb->ip_summed to CHECKSUM_UNNECSSARY unconditionally like
that.

You can only set that for protocols your chip actually supports.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-06-13 14:30 +0200
  Re: [patch net-next] net: hns: add skb_reset_mac_header() after  skb being alloc David Miller <davem@davemloft.net> - 2016-06-15 07:50 +0200
    Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb  being alloc Yisen Zhuang <Yisen.zhuang@huawei.com> - 2016-06-15 12:40 +0200
      Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb  being alloc Yisen Zhuang <Yisen.zhuang@huawei.com> - 2016-06-20 09:20 +0200
        Re: [patch net-next] net: hns: add skb_reset_mac_header() after  skb being alloc David Miller <davem@davemloft.net> - 2016-06-20 18:10 +0200

csiph-web