Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3 idle states

From	Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3 idle states
Date	2016-06-15 07:00 +0200
Message-ID	<rKb5L-6mk-1@gated-at.bofh.it> (permalink)
References	<rHOZH-2EF-3@gated-at.bofh.it> <rHOZH-2EF-1@gated-at.bofh.it> <rJC81-8aA-7@gated-at.bofh.it> <rJU4W-3FD-15@gated-at.bofh.it> <rJURk-4dg-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 06/14/2016 04:59 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2016-06-14 at 16:17 +0530, Shreyas B Prabhu wrote:
> 
>>
>> I ignored adding this check because this is part of initcall and we are
>> unlikely to run out of memory at this state. But I'll add the check in
>> next version.
> 
> Why do you malloc the u64 array and not the string pointer array ?
> Shouldn't you either have both on stack or both allocated ?
> 

Yes. I'll make this consistent.

Thanks,
Shreyas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3  idle states Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-13 17:40 +0200
  Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3  idle states Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2016-06-14 12:50 +0200
    Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3  idle states Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-06-14 13:40 +0200
      Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3  idle states Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2016-06-15 07:00 +0200

csiph-web