Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1424918
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch] events/amd/power add support for fam16h model30h |
| Date | 2016-06-17 12:40 +0200 |
| Message-ID | <rKZlU-5mE-35@gated-at.bofh.it> (permalink) |
| References | <rKMI1-4TD-1@gated-at.bofh.it> <rKMRH-4YX-5@gated-at.bofh.it> <rKZlU-5mE-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 17, 2016 at 06:07:47PM +0800, Huang Rui wrote:
> Agree with you. If the some chips are not stable, we can add a check
> to ignore them with family and model id.
So if family 0x16 is not "stable" as you say, we probably should keep
the cpu_match array too.
Actually, you could merge the feature check in there too, AFAICT, from
looking at x86_match_cpu() and if I'm not misreading it:
static const struct x86_cpu_id cpu_match[] = {
{ .vendor = X86_VENDOR_AMD, .family = 0x15, .model = X86_MODEL_ANY, .feature = X86_FEATURE_ACC_POWER },
};
And then you can drop the boot_cpu_has() test as x86_match_cpu() does it
for you.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch] events/amd/power add support for fam16h model30h Vince Weaver <vincent.weaver@maine.edu> - 2016-06-16 23:10 +0200
Re: [patch] events/amd/power add support for fam16h model30h Borislav Petkov <bp@alien8.de> - 2016-06-16 23:20 +0200
Re: [patch] events/amd/power add support for fam16h model30h Borislav Petkov <bp@alien8.de> - 2016-06-17 12:40 +0200
Re: [patch] events/amd/power add support for fam16h model30h Vince Weaver <vincent.weaver@maine.edu> - 2016-06-17 18:00 +0200
Re: [patch] events/amd/power add support for fam16h model30h Borislav Petkov <bp@alien8.de> - 2016-06-17 18:30 +0200
Re: [patch] events/amd/power add support for fam16h model30h Vince Weaver <vincent.weaver@maine.edu> - 2016-06-17 19:40 +0200
Re: [patch] events/amd/power add support for fam16h model30h Borislav Petkov <bp@alien8.de> - 2016-06-17 20:20 +0200
Re: [patch] events/amd/power add support for fam16h model30h Vince Weaver <vincent.weaver@maine.edu> - 2016-06-17 21:10 +0200
Re: [patch] events/amd/power add support for fam16h model30h Vince Weaver <vincent.weaver@maine.edu> - 2016-06-17 21:50 +0200
Re: [patch] events/amd/power add support for fam16h model30h Borislav Petkov <bp@alien8.de> - 2016-06-17 22:00 +0200
Re: [patch] events/amd/power add support for fam16h model30h Borislav Petkov <bp@alien8.de> - 2016-06-17 22:00 +0200
csiph-web