Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424845

Re: [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel()

Show all headers | View raw

Am Freitag, 17. Juni 2016, 12:16:19 schrieb Dan Carpenter:

Hi Dan,

> We accidentally return PTR_ERR(NULL) which is success but we should
> return -ENOMEM.
> 
> Fixes: 355912852115 ('crypto: drbg - use CTR AES instead of ECB AES')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Stephan Mueller <smueller@chronox.de>

That points to an error in the documentation of skcipher_request_alloc.

I will send a follow-up patch.
> 
> diff --git a/crypto/drbg.c b/crypto/drbg.c
> index ded8638..6872d15 100644
> --- a/crypto/drbg.c
> +++ b/crypto/drbg.c
> @@ -1686,7 +1686,7 @@ static int drbg_init_sym_kernel(struct drbg_state
> *drbg) if (!req) {
>  		pr_info("DRBG: could not allocate request queue\n");
>  		drbg_fini_sym_kernel(drbg);
> -		return PTR_ERR(req);
> +		return -ENOMEM;
>  	}
>  	drbg->ctr_req = req;
>  	skcipher_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG,


Ciao
Stephan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] crypto: drbg - fix an error code in drbg_init_sym_kernel() Dan Carpenter <dan.carpenter@oracle.com> - 2016-06-17 11:20 +0200
  Re: [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel() Stephan Mueller <smueller@chronox.de> - 2016-06-17 11:30 +0200
    Re: [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel() Stephan Mueller <smueller@chronox.de> - 2016-06-17 11:30 +0200
  Re: [patch] crypto: drbg - fix an error code in  drbg_init_sym_kernel() Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-20 14:10 +0200

csiph-web