[RESEND PATCH 3/4] tty/serial: atmel: add comment for the ring buffer size macro

From	Nicolas Ferre <nicolas.ferre@atmel.com>
Newsgroups	linux.kernel
Subject	[RESEND PATCH 3/4] tty/serial: atmel: add comment for the ring buffer size macro
Date	2016-06-17 12:10 +0200
Message-ID	<rKYSS-5cu-9@gated-at.bofh.it> (permalink)
References	<rKYSS-5cu-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Ludovic Desroches <ludovic.desroches@atmel.com>

There is a macro named ATMEL_SERIAL_RINGSIZE which suggesting that it
corresponds to the real size of the ring buffer. Let warn people that
there is a factor of four since allocation size is
sizeof(struct atmel_uart_char) * ATMEL_SERIAL_RINGSIZE.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
 drivers/tty/serial/atmel_serial.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 6c1ec7d0d497..857016367a7a 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -108,6 +108,12 @@ struct atmel_uart_char {
 	u16		ch;
 };
 
+/*
+ * Be careful, the real size of the ring buffer is
+ * sizeof(atmel_uart_char) * ATMEL_SERIAL_RINGSIZE. It means that ring buffer
+ * can contain up to 1024 characters in PIO mode and up to 4096 characters in
+ * DMA mode.
+ */
 #define ATMEL_SERIAL_RINGSIZE 1024
 
 /*
-- 
2.9.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[RESEND PATCH 3/4] tty/serial: atmel: add comment for the ring buffer size macro Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-17 12:10 +0200

csiph-web