Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424879

Re: [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate

Show all headers | View raw

On Thu, Jun 16, 2016 at 9:24 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> msm_set_termios() is called whenever the tty is opened. Setting the baud
> rate requires a full reset of the msm serial block, even when the rate
> is unchanged. In the case when the same uart is used as console this
> reset will discard any console output data still being clocked out of
> the TX fifo.
>
> By skipping the rate-change in the case where the baud rate is unchanged
> since last request we can avoid the reset and the discarding of the
> data.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Tested-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

I no longer see this type of corruption on serial console

[    6.325118] ALSA device �[    6.333338] Freeing unused kernel
memory: 572K (ffffffc000c10000 - ffffffc000c9f000)
[   13.800269]  remoteproc2: remote processor a20400�[  OK  ] Started
Start the WCN core.
[ �         Starting Update UTMP about System Runlevel Changes...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] tty: serial: msm_serial: Don't reset uart on set_termios Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-13 21:10 +0200
  Re: [RFC PATCH] tty: serial: msm_serial: Don't reset uart on set_termios Pramod Gurav <pramod.gurav@linaro.org> - 2016-06-15 15:00 +0200
  Re: [RFC PATCH] tty: serial: msm_serial: Don't reset uart on  set_termios Stephen Boyd <sboyd@codeaurora.org> - 2016-06-16 03:20 +0200
  [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-16 20:30 +0200
    Re: [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate Nicolas Dechesne <nicolas.dechesne@linaro.org> - 2016-06-17 12:10 +0200
      Re: [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate Nicolas Dechesne <nicolas.dechesne@linaro.org> - 2016-06-21 12:20 +0200
        Re: [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-22 12:10 +0200
    Re: [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate Stephen Boyd <sboyd@codeaurora.org> - 2016-06-21 02:00 +0200

csiph-web