Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1424837
| From | Zhaoyang Huang <zhaoyang.huang@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RESEND PATCH v2 1/2] power/cpuidle: enhance the precision of state select |
| Date | 2016-06-17 11:20 +0200 |
| Message-ID | <rKY6t-4F5-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
In previous version, cpu_pm_enter is invoked after the governor
select the state, which cause the executing time of cpu_pm_enter
is included in the idle time. Moving it before the state selection.
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>
---
kernel/sched/idle.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index bd12c6c..929da2e 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -5,6 +5,7 @@
#include <linux/cpu.h>
#include <linux/cpuidle.h>
#include <linux/cpuhotplug.h>
+#include <linux/cpu_pm.h>
#include <linux/tick.h>
#include <linux/mm.h>
#include <linux/stackprotector.h>
@@ -130,6 +131,7 @@ static void cpuidle_idle_call(void)
struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);
struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
int next_state, entered_state;
+ int ret;
/*
* Check if the idle task must be rescheduled. If it is the
@@ -174,12 +176,16 @@ static void cpuidle_idle_call(void)
/*
* Ask the cpuidle framework to choose a convenient idle state.
*/
- next_state = cpuidle_select(drv, dev);
- entered_state = call_cpuidle(drv, dev, next_state);
- /*
- * Give the governor an opportunity to reflect on the outcome
- */
- cpuidle_reflect(dev, entered_state);
+ ret = cpu_pm_enter();
+ if (!ret) {
+ next_state = cpuidle_select(drv, dev);
+ entered_state = call_cpuidle(drv, dev, next_state);
+ cpu_pm_exit();
+ /*
+ * Give the governor an opportunity to reflect on the outcome
+ */
+ cpuidle_reflect(dev, entered_state);
+ }
}
exit_idle:
--
1.7.9.5
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[RESEND PATCH v2 1/2] power/cpuidle: enhance the precision of state select Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-17 11:20 +0200
[RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-17 11:20 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 11:30 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-17 13:20 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Thomas Gleixner <tglx@linutronix.de> - 2016-06-17 14:00 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-20 03:20 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-22 05:10 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 09:10 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-23 09:30 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 10:30 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 10:40 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-23 10:50 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Thomas Gleixner <tglx@linutronix.de> - 2016-06-23 12:20 +0200
Re: [RESEND PATCH v2 2/2] power/idle: enhance the precision of sleep_length Zhaoyang Huang <zhaoyang.huang@linaro.org> - 2016-06-23 10:40 +0200
csiph-web